Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[HLSL][RootSignature] Implement Lexing of DescriptorTables #122981
[HLSL][RootSignature] Implement Lexing of DescriptorTables #122981
Changes from 12 commits
98deff6
5f43ed8
dc0c7ba
c5d3881
dc784ff
82c645d
1c95e6d
d648f4c
de2f62e
f557d5a
de364d8
35c1566
8ac979c
0c372bf
e58c89a
aa7a73d
ca2a2cb
8345ff1
5439fa8
cf9788e
6a5545f
7f27295
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this needed?
In general it is also best to prefer forward declarations in headers rather than including headers where possible to reduce compile time overhead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Removed this and the other no longer needed headers