[RISCV][llvm-exegesis] Disable pseudo instructions in allowAsBackToBack. #122986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents crashes trying to encode pseudo instuctions. Tested on HiFive Premier P550.
|
@llvm/pr-subscribers-tools-llvm-exegesis Author: Craig Topper (topperc) ChangesPrevents crashes trying to encode pseudo instuctions. Tested on HiFive Premier P550. Fixes #122974 Full diff: https://github.com/llvm/llvm-project/pull/122986.diff 1 Files Affected:
diff --git a/llvm/tools/llvm-exegesis/lib/RISCV/Target.cpp b/llvm/tools/llvm-exegesis/lib/RISCV/Target.cpp
index 5636782bdf7f6f..911713d4e0aa59 100644
--- a/llvm/tools/llvm-exegesis/lib/RISCV/Target.cpp
+++ b/llvm/tools/llvm-exegesis/lib/RISCV/Target.cpp
@@ -124,6 +124,10 @@ class ExegesisRISCVTarget : public ExegesisTarget {
ArrayRef<unsigned> getUnavailableRegisters() const override;
+ bool allowAsBackToBack(const Instruction &Instr) const override {
+ return !Instr.Description.isPseudo();
+ }
+
Error randomizeTargetMCOperand(const Instruction &Instr, const Variable &Var,
MCOperand &AssignedValue,
const BitVector &ForbiddenRegs) const override;
|
mikhailramalho
approved these changes
Jan 15, 2025
boomanaiden154
approved these changes
Jan 15, 2025
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/73/builds/11738 Here is the relevant piece of the build log for the reference |
paulhuggett
pushed a commit
to paulhuggett/llvm-project
that referenced
this pull request
Jan 16, 2025
…ck. (llvm#122986) Prevents crashes trying to encode pseudo instuctions. Tested on HiFive Premier P550. Fixes llvm#122974
DKLoehr
pushed a commit
to DKLoehr/llvm-project
that referenced
this pull request
Jan 17, 2025
…ck. (llvm#122986) Prevents crashes trying to encode pseudo instuctions. Tested on HiFive Premier P550. Fixes llvm#122974
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents crashes trying to encode pseudo instuctions. Tested on HiFive Premier P550.
Fixes #122974