[libcxx][test] Fix a test for the range of file offsets on ARMv7 Linux targets. #123449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ets. XFAIL offset_range test on the ARMv7 targets (32-bit). Ref PR llvm#122798
llvmbot
added
the
libc++
|
@llvm/pr-subscribers-libcxx Author: Vladimir Vereschaka (vvereschaka) ChangesXFAIL the Ref PR #122798 Full diff: https://github.com/llvm/llvm-project/pull/123449.diff 1 Files Affected:
diff --git a/libcxx/test/std/input.output/file.streams/fstreams/ifstream.members/offset_range.pass.cpp b/libcxx/test/std/input.output/file.streams/fstreams/ifstream.members/offset_range.pass.cpp
index 5afd4465db31e0..9bb52c8ac8f481 100644
--- a/libcxx/test/std/input.output/file.streams/fstreams/ifstream.members/offset_range.pass.cpp
+++ b/libcxx/test/std/input.output/file.streams/fstreams/ifstream.members/offset_range.pass.cpp
@@ -28,6 +28,11 @@
//
// XFAIL: target=powerpc-{{.+}}-aix{{.*}}
+// By default, off_t is typically a 32-bit integer on ARMv7 Linux systems,
+// meaning it can represent file sizes up to 2GB (2^31 bytes) only.
+//
+// XFAIL: target=armv7{{.*}}-{{.+}}-linux{{.*}}
+
#include <fstream>
#include <iostream>
#include <cassert>
|
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
mstorsjo
reviewed
Jan 18, 2025
| // By default, off_t is typically a 32-bit integer on ARMv7 Linux systems, | ||
| // meaning it can represent file sizes up to 2GB (2^31 bytes) only. | ||
| // | ||
| // XFAIL: target=armv7{{.*}}-{{.+}}-linux{{.*}} |
There was a problem hiding this comment.
This reasoning looks and sounds reasonable… however it doesn’t seem to hold universally, because we do have some existing CI test configurations that also run on armv7 Linux, where this test does pass. It didn’t trigger this XFAIL though, because the triple has a slightly different form - target=armv7l-linux-gnueabihf, so there’s no vendor field. If you’d tweak the regex to not require a vendor field, I think it would match - and this XFAIL would trigger…
Apparently that setup has got 64 bit off_t by default?
There was a problem hiding this comment.
Hm, ok. I have marked this test as UNSUPPORTED for armv7-unknown-linux-gnueabihf targets in that case. It will fix the failed test on the public buildbot, that is broken for more than 3 days already.
https://lab.llvm.org/buildbot/#/builders/38
https://lab.llvm.org/buildbot/#/builders/38/builds/1865/steps/15/logs/stdio
Apparently that setup has got 64 bit off_t by default?
The buildbot's ARMv7 board setup has 32-bit off_t by default (as it expected):
ubuntu@jetson6:~$ ./t.tmp.exe
__WORDSIZE: 32
sizeof(off_t): 4
^C
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/55/builds/5771 Here is the relevant piece of the build log for the reference |
|
@vvereschaka Please wait for @llvm/reviewers-libcxx approval until you merge libc++ changes next time. I get that it's been a few days that the buildbot was red, but people usually don't work on the weekend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mark the
offset_rangetest as UNSUPPORTED for thearmv7-unknown-linux-gnueabihftarget (32-bit).Ref PR #122798