[llvm][NFC] Remove CV-qualified base class in PassManagerInternal.h #124193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@llvm/pr-subscribers-llvm-ir Author: Henry Jiang (mustartt) ChangesThis resolves the https://lab.llvm.org/buildbot/#/builders/168/builds/7756 Full diff: https://github.com/llvm/llvm-project/pull/124193.diff 1 Files Affected:
diff --git a/llvm/include/llvm/IR/PassManagerInternal.h b/llvm/include/llvm/IR/PassManagerInternal.h
index 4ada6ee5dd6831..4b6fad9b417889 100644
--- a/llvm/include/llvm/IR/PassManagerInternal.h
+++ b/llvm/include/llvm/IR/PassManagerInternal.h
@@ -23,6 +23,7 @@
#include "llvm/Support/raw_ostream.h"
#include <memory>
#include <utility>
+#include <type_traits>
namespace llvm {
@@ -167,7 +168,7 @@ template <typename IRUnitT, typename ResultT> class ResultHasInvalidateMethod {
// ambiguous if there were an invalidate member in the result type.
template <typename T, typename U> static DisabledType NonceFunction(T U::*);
struct CheckerBase { int invalidate; };
- template <typename T> struct Checker : CheckerBase, T {};
+ template <typename T> struct Checker : CheckerBase, std::remove_cv_t<T> {};
template <typename T>
static decltype(NonceFunction(&Checker<T>::invalidate)) check(rank<1>);
|
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
mustartt
changed the title
|
LLVM Buildbot has detected a new failure on builder Full details are available at: https://lab.llvm.org/buildbot/#/builders/59/builds/11619 Here is the relevant piece of the build log for the reference |
Flaky test https://lab.llvm.org/buildbot/#/builders/59/builds/11620 is passing, ignoring. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves the
-Wignored-qualifierswarning introduced by the new warnign in #121419. First caught in buildbotppc64le-lld-multistage-testhttps://lab.llvm.org/buildbot/#/builders/168/builds/7756