-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Premerge] Add flang-rt #128678
[Premerge] Add flang-rt #128678
Changes from all commits
9ebeeae
afada27
8345c19
da2a539
93a7713
a8a9323
a7b728c
b0d0879
8c41ae6
e8b028a
67809ce
d2144a0
26bb93a
6e7d7fd
bed0c3f
59ec1ee
637f662
881b6bf
3d95f2e
b2354ff
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,15 +18,14 @@ function compute-projects-to-test() { | |
shift | ||
projects=${@} | ||
for project in ${projects}; do | ||
echo "${project}" | ||
case ${project} in | ||
lld) | ||
for p in bolt cross-project-tests; do | ||
for p in lld bolt cross-project-tests; do | ||
echo $p | ||
done | ||
;; | ||
llvm) | ||
for p in bolt clang clang-tools-extra lld lldb mlir polly; do | ||
for p in llvm bolt clang clang-tools-extra lld lldb mlir polly; do | ||
echo $p | ||
done | ||
# Flang is not stable in Windows CI at the moment | ||
|
@@ -36,21 +35,30 @@ function compute-projects-to-test() { | |
;; | ||
clang) | ||
# lldb is temporarily removed to alleviate Linux pre-commit CI waiting times | ||
for p in clang-tools-extra compiler-rt cross-project-tests; do | ||
for p in clang clang-tools-extra compiler-rt cross-project-tests; do | ||
echo $p | ||
done | ||
;; | ||
clang-tools-extra) | ||
echo libc | ||
for p in clang-tools-extra libc; do | ||
echo $p | ||
done | ||
;; | ||
mlir) | ||
echo mlir | ||
# Flang is not stable in Windows CI at the moment | ||
if [[ $isForWindows == 0 ]]; then | ||
echo flang | ||
fi | ||
;; | ||
flang-rt) | ||
# Flang is not stable in Windows CI at the moment | ||
if [[ $isForWindows == 0 ]]; then | ||
echo flang | ||
fi | ||
;; | ||
*) | ||
# Nothing to do | ||
echo "${project}" | ||
;; | ||
esac | ||
done | ||
|
@@ -65,6 +73,11 @@ function compute-runtimes-to-test() { | |
echo $p | ||
done | ||
;; | ||
flang) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. If a patch touches There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Not the case. If you one day rewrite the mechanism, consider giving different names to "top-level directory in the repository", "valid argument to LLVM_ENABLE_PROJECTS", and "valid argument to LLVM_ENABLE_RUNTIMES". They are currently all called "projects" in some form. |
||
for p in flang-rt; do | ||
echo $p | ||
done | ||
;; | ||
*) | ||
# Nothing to do | ||
;; | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there a reason this moved?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At the old location, it would always output the project, including "flang-rt". I could have added an if-condition to not print flang-rt, or filter it out afterwards in like in
exclude-linux
/exclude-windows
but that doesn't seem its purpose, or just let it add it to "LLVM_ENABLE_PROJECTS" even though it it ignored there (like "llvm"). I found the best solution is to change the function to let each case decide whether to prints itself, which would also e.g. allow to not print "llvm" at some point.I tried to avoid modifying https://github.com/llvm/llvm-project/blob/main/.ci/generate-buildkite-pipeline-premerge itself, there are copies of that code, like in https://github.com/llvm/llvm-project/blob/main/.github/workflows/premerge.yaml, but I could not get around changing
all_projects
.