Skip to content

[flang] Fix POSIX.1/XPG checks in intrinsics-library.cpp #201072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rorth merged 4 commits into from
Jul 30, 2026
Merged

[flang] Fix POSIX.1/XPG checks in intrinsics-library.cpp #201072

Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1aad7df
[flang] Fix POSIX.1/XPG checks in intrinsics-library.cpp
rorth Jun 2, 2026
58fa090
Check both `_POSIX_C_SOURCE` and `_POSIX_VERSION`, `_XOPEN_SOURCE` an…
rorth Jun 2, 2026
56a8100
Fix POSIX.1/XPG check.
rorth Jul 30, 2026
9485992
Don't include <unistd.h> on Windows.
rorth Jul 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions flang/lib/Evaluate/intrinsics-library.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -440,7 +440,8 @@ struct HostRuntimeLibrary<std::complex<double>, LibraryVersion::Libm> {
// clang libc++ (ok in GNU libstdc++). Instead, the Posix libm
// extensions are used when available below.

#if _POSIX_C_SOURCE >= 200112L || _XOPEN_SOURCE >= 600
#if _POSIX_C_SOURCE >= 200112L || _POSIX_VERSION >= 200112L || \

@MaskRay MaskRay Jul 25, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file doesn't include unistd.h, _POSIX_VERSION and _XOPEN_VERSION feel dead to me.

_XOPEN_SOURCE >= 600 || _XOPEN_VERSION >= 600
/// Define libm extensions
/// Bessel functions are defined in POSIX.1-2001.

Expand Down Expand Up @@ -557,7 +558,8 @@ struct HostRuntimeLibrary<long double, LibraryVersion::LibmExtensions> {
static_assert(map.Verify(), "map must be sorted");
};
#endif // HAS_FLOAT80 || HAS_LDBL128
#endif //_POSIX_C_SOURCE >= 200112L || _XOPEN_SOURCE >= 600
#endif //_POSIX_C_SOURCE >= 200112L || _POSIX_VERSION >= 200112L ||
//_XOPEN_VERSION >= 600 || _XOPEN_VERSION >= 600

#ifdef _WIN32
template <> struct HostRuntimeLibrary<double, LibraryVersion::LibmExtensions> {
Expand Down