workflows: Merge release-doxygen into release-documenation - #214366
Open
tstellar wants to merge 37 commits into
Open
workflows: Merge release-doxygen into release-documenation#214366tstellar wants to merge 37 commits into
tstellar wants to merge 37 commits into
Conversation
tstellar
force-pushed
the
users/tstellar/merge-doxygen
branch
2 times, most recently
from
August 6, 2026 22:15
d909a73 to
049b8c8
Compare
Removed the environment declaration from the validation job and split out the www-releases update into a separate job. This makes it safe and possible to add a pull_request trigger so we can at least test building the documentation when someone submits a pull request.
This reverts commit a5d98fb.
This reverts commit f90c6dd.
This reverts commit 1794326.
This reverts commit ef443b1.
These two workflows use the same script and have the same structure, so it's easier just to have one job that builds both.
tstellar
force-pushed
the
users/tstellar/merge-doxygen
branch
2 times, most recently
from
August 6, 2026 22:59
d9ae673 to
18caded
Compare
tstellar
changed the title
tstellar
marked this pull request as ready for review
August 7, 2026 03:51
tstellar
marked this pull request as draft
August 7, 2026 03:56
tstellar
force-pushed
the
users/tstellar/merge-doxygen
branch
from
August 7, 2026 03:57
18caded to
0fd1b98
Compare
Contributor
Author
|
Ping. |
c-rhodes
reviewed
Aug 18, 2026
Comment on lines
-180
to
-182
| environment: | ||
| deployment: false | ||
| name: release |
Contributor
There was a problem hiding this comment.
not obvious to me why this is dropped?
Contributor
Author
There was a problem hiding this comment.
I think I did this for debugging, but I've added it back now.
| needs: | ||
| - release-doxygen-validate-input | ||
| env: | ||
| upload: ${{ inputs.upload && !contains(inputs.release-version, 'rc') }} |
Contributor
There was a problem hiding this comment.
upload was disabled for RCs, this is no longer the case, is that intentional?
Contributor
Author
There was a problem hiding this comment.
I don't know why we had it disabled for rc builds. We build the documentation for rc builds, and I don't see a good reason not to for the doxygen too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These two workflows use the same script and have the same structure,
so it's easier just to have one job that builds both.