Skip to content

[Support][test] Fix OpenDirectoryAsFileForRead test on AIX and z/OS #216241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DanielCChen merged 2 commits into from
Aug 14, 2026
Merged

[Support][test] Fix OpenDirectoryAsFileForRead test on AIX and z/OS #216241

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d2983e0
[Support][test] Fix OpenDirectoryAsFileForRead test on AIX and z/OS
DanielCChen Aug 14, 2026
32123be
To address review comments.
DanielCChen Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions llvm/unittests/Support/Path.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2042,6 +2042,10 @@ TEST_F(FileSystemTest, OpenDirectoryAsFileForRead) {
Expected<fs::file_t> FD = fs::openNativeFileForRead(TestDirectory);
#ifdef _WIN32
EXPECT_EQ(errorToErrorCode(FD.takeError()), errc::is_a_directory);
#elif defined(_AIX) || defined(__MVS__)
Comment thread
DanielCChen marked this conversation as resolved.
Outdated
// On AIX and z/OS, open() on a directory with O_RDONLY fails immediately
// with EISDIR, unlike Linux where open() succeeds and read() returns EISDIR.
EXPECT_EQ(errorToErrorCode(FD.takeError()), errc::is_a_directory);
#else
ASSERT_THAT_EXPECTED(FD, Succeeded());
scope_exit Close([&] { fs::closeFile(*FD); });
Expand Down
Loading