Skip to content

[DWARF] Fix DW_OP_LLVM_user sub-operation name lookup. #217480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
enferex merged 2 commits into from
Aug 20, 2026
+10 −1
Merged

[DWARF] Fix DW_OP_LLVM_user sub-operation name lookup. #217480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
79fc615
[DWARF] Fix DW_OP_LLVM_user sub-operation name lookup.
enferex Aug 19, 2026
64473cc
Added comment to the user string-to-enum roundtrip test.
enferex Aug 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion llvm/lib/BinaryFormat/Dwarf.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,7 +192,8 @@ static StringRef LlvmUserOperationEncodingString(unsigned Encoding) {
static unsigned
getLlvmUserOperationEncoding(StringRef LlvmUserOperationEncodingString) {
unsigned E = StringSwitch<unsigned>(LlvmUserOperationEncodingString)
#define HANDLE_DW_OP_LLVM_USEROP(ID, NAME) .Case(#NAME, DW_OP_LLVM_##NAME)
#define HANDLE_DW_OP_LLVM_USEROP(ID, NAME) \
.Case("DW_OP_LLVM_" #NAME, DW_OP_LLVM_##NAME)
#include "llvm/BinaryFormat/Dwarf.def"
.Default(0);
assert(E && "unhandled DWARF operation string with LLVM user op");
Expand Down
8 changes: 8 additions & 0 deletions llvm/unittests/BinaryFormat/DwarfTest.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,14 @@ TEST(DwarfTest, getOperationEncoding) {
EXPECT_EQ(0u, getOperationEncoding("DW_OP_hi_user"));
}

TEST(DwarfTest, SubOperationEncoding) {
// Test that the enum-to-string user encodings roundtrip.
EXPECT_EQ("DW_OP_LLVM_nop",
SubOperationEncodingString(DW_OP_LLVM_user, DW_OP_LLVM_nop));
EXPECT_EQ(DW_OP_LLVM_nop,
getSubOperationEncoding(DW_OP_LLVM_user, "DW_OP_LLVM_nop"));
}

TEST(DwarfTest, LanguageStringOnInvalid) {
// This is invalid, so it shouldn't be stringified.
EXPECT_EQ(StringRef(), LanguageString(0));
Expand Down
Loading