Skip to content

Comments

Reapply "[sanitize] Skip build requests older than 3h" (#295)#316

Merged
vitalybuka merged 1 commit intomainfrom
1h
Nov 20, 2024
Merged

Reapply "[sanitize] Skip build requests older than 3h" (#295)#316
vitalybuka merged 1 commit intomainfrom
1h

Conversation

@vitalybuka
Copy link
Contributor

@vitalybuka vitalybuka commented Nov 20, 2024

Buildbot is not ready yet #250 (comment)

This reverts commit 26a33cd.

@vitalybuka vitalybuka requested a review from fmayer November 20, 2024 02:29
@vitalybuka vitalybuka changed the title Revert "Reapply "[sanitize] Don't build older then 1h requests"" (#296) Reapply "[sanitize] Don't build older then 1h requests" (#296) Nov 20, 2024
@vitalybuka vitalybuka changed the title Reapply "[sanitize] Don't build older then 1h requests" (#296) Reapply "[sanitize] Don't build older then 1h requests" (#295) Nov 20, 2024
@fmayer
Copy link
Contributor

fmayer commented Nov 20, 2024 •
edited
Loading

Does this mean that again we can't manually kick off builds anymore?

saw the "forced-build-scheduler", so seems not

@vitalybuka vitalybuka changed the title Reapply "[sanitize] Don't build older then 1h requests" (#295) Reapply "[sanitize] Don't build older than 1h requests" (#295) Nov 20, 2024
@vitalybuka vitalybuka changed the title Reapply "[sanitize] Don't build older than 1h requests" (#295) Reapply "[sanitize] Skip build requests older than 3h" (#295) Nov 20, 2024
@vitalybuka
Copy link
Contributor Author

vitalybuka commented Nov 20, 2024

Does this mean that again we can't manually kick off builds anymore?

You can kick, "${BUILDBOT_SCHEDULER}" == "force-build-scheduler" is for that

@vitalybuka vitalybuka merged commit f09f2a7 into main Nov 20, 2024
vitalybuka added a commit that referenced this pull request Apr 8, 2025
@vitalybuka
Revert "Reapply "[sanitize] Skip build requests older than 3h" (#295) (…
6fcd356 
…#316)"

For #250.

This reverts commit f09f2a7.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fmayer fmayer fmayer approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vitalybuka @fmayer