-
Notifications
You must be signed in to change notification settings - Fork 523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[torch-mlir] Support lowering of aten constraint ops #3943
base: main
Are you sure you want to change the base?
Conversation
praveen-g-ctt
commented
Jan 7, 2025
- aten::sym_constrain_range
- aten::sym_constrain_range_for_size
- aten::_assert_scalar
f59bd0b
to
1dd573c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
I'd like to request a few small changes, and I'd also like to at least have a discussion for context on these ops and their relationship with torch.symbolic_int
and torch.bind_symbolic_shape
.
f42e9ba
to
cc7de9a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the work, Praveen.
After looking at the example IR, I think it is totally fine to merge this as-is. In future patches, it would be good to add some folders (e.g., if min and max are both %none
's, just erase it). And if we see other examples where these ops could inform symbolic shape constraints in a useful way for codegen, we can make changes then.
1. aten::sym_constrain_range 2. aten::sym_constrain_range_for_size 3. aten::_assert_scalar
cc7de9a
to
de3115d
Compare
Sure Zach. Will add folders in future patches. |