Meteor 1.8 #42
Open
Meteor 1.8 #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KoenLav
commented
Oct 16, 2018
| @@ -0,0 +1,89 @@ | |||
| Package.describe({ | |||
There was a problem hiding this comment.
I had to include this package to update its dependency from the Meteor stylus package to the coagmano:stylus package.
|
Nice good job! I'll review it this weekend. |
|
I deployed it to production; found no errors in APM, but it seems
APM-engine is producing some errors.
So might want to hold off merging.
I don't have time to look into it again the next couple of weeks though :(
Op wo 17 okt. 2018 17:50 schreef Leon Machens <[email protected]>:
… Nice good job! I'll review it this weekend.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#42 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AL3qWGYFidNDkambSFPHbr0C4xlser5Yks5ul1G2gaJpZM4XiRMe>
.
|
|
Alright |
|
@jankapunkt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated to Meteor 1.8