-
Notifications
You must be signed in to change notification settings - Fork 2
Merge in tests from Comfortstat #58
Conversation
In order to get automatic tests when commiting code
Update for the automatic tests
Git merge origin/workflow
… the body part and cleand up in api_fetch_test.go file
This backs out commit 4e22141.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First review, I've been a little pedantic with the empty rows, but I've tried not to comment much about things Alexander brought up
EDIT: I think I've chosen the wrong setting for my review, it should've been a comment
|
https://github.com/lmas/d0020e_code/actions/runs/13136134197/job/36651836457#step:5:10 shows errors in the testing logs?? |
…e so it updates as soon as a new hour is reached
| t.set_SEKprice(w, r) | ||
| case "desired_temp": | ||
| t.set_desiredTemp(w, r) | ||
| case "MinTemperature": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An observation here, there's no need for action.
These aren't function names and didn't need to be updated. I admit I could have spent more time writing better comments and clarify this better.
Have you thought about any side effects this change may have? This block of code is part of your system's public API.
Changing these names here resulted in a change in the API and broke for example the GUI app and the influxdb system (as both have hard-coded dependencies on the previous names).
This is why we do code reviews, to find oversights like this.
|
Closing, want to merge in to new dev branch instead and preserve the stability in master. |
Let's finish up the work until next week and review the code.
Purpose of the review:
Activity log: