Embezzler lucky #2367
Embezzler lucky #2367
Conversation
packages/garbo/src/outfit/target.ts
Outdated
| @@ -44,6 +44,9 @@ export function meatTargetOutfit( | |||
| if (target === $location`Crab Island`) { | |||
| const meat = meatDrop($monster`giant giant crab`) + songboomMeat(); | |||
| outfit.modifier.push(`${meat / 100} Meat Drop`, "-tie"); | |||
| } else if (target === $location`Cobb's Knob Treasury`) { | |||
There was a problem hiding this comment.
unfortunately I think we need a more precise check for this given that wanderers can be placed in the treasury (they can't be placed in crab island)
There was a problem hiding this comment.
Added a check for Lucky!, hopefully that should work
packages/garbo/src/tasks/barfTurn.ts
Outdated
| do: () => getBestLuckyAdventure().location, | ||
| prepare: () => { | ||
| if (!have($effect`Lucky!`)) { | ||
| retrieveItem($item`Eight Days a Week Pill Keeper`); | ||
| cliExecute("pillkeeper semirare"); | ||
| if (!have($effect`Lucky!`)) { | ||
| set("_freePillKeeperUsed", true); | ||
| return; | ||
| } | ||
| } | ||
| }, |
There was a problem hiding this comment.
I think we should use a system similar to the one you've set up in embezzler.ts and for similar reasons (that is, separate lucky source from lucky execution).
BUT, the turns field should remain on the sources rather than on the lucky adventure task.
There was a problem hiding this comment.
Does that cause any problems with the task itself having spendsTurn: false, but actually having a turns field?
There was a problem hiding this comment.
Did this and also added counting the embezzler sources in copyTargetCount
packages/garbo/src/target/fights.ts
Outdated
| @@ -1098,8 +1015,9 @@ export const copyTargetSources = [ | |||
| ]; | |||
|
|
|||
| export function copyTargetCount(): number { | |||
There was a problem hiding this comment.
Is this worth having two separate functions (or a boolean arg) for? is everywhere we call copyTargetCount a place where we want to include embezzlers? even if you're fighting, say, roaches?
Shiverwarp
force-pushed
the
embezzler-lucky
branch
from
b07c3c2 to
40b2500
Compare
| @@ -60,18 +59,15 @@ function drivebyValue(): number { | |||
| } | |||
|
|
|||
| function entendreValue(): number { | |||
| const targets = copyTargetCount(); | |||
| const targets = highMeatMonsterCount("Scepter"); // Scepter can cause circular logic | |||
There was a problem hiding this comment.
could you do a quick refactor to both have highmeatMonsterCount passed in rather than calculated both times, and to deduplicate some of the logic here?
Problem I'm unsure how to fix: We need to count how many embezzlers we're fighting here to account for them when buffing with potions (I don't think we should actually account for them cost wise, but we are spending turns fighting them, so that might cause us to run out of turns of buffs before we finish all our copiers, so the copytargetcount might need updating to account for that?