Fix critical bugs in miniRedis client - #1
Conversation
- Rewrote `read()` to implement a proper RESP parser. - Fixed binary safety issue where data containing `\r\n` caused parsing errors. - Changed `read()` to return a single response per call instead of consuming all pending responses, aligning with standard client behavior and `example.php`. - Implemented internal buffering to handle stream fragmentation and pipelining correctly. - Improved error handling and readability.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Identified and fixed major bugs in
miniRedis.php:\r\n, which corrupted binary data containing those characters. The new implementation parses RESP bulk strings by length.read()consumed all pending responses and returned an array, which contradicted the usage inexample.phpand standard Redis client patterns. It now returns one response per call.Verified with a reproduction script covering binary keys and pipelined commands.
PR created automatically by Jules for task 13553854678338863919 started by @lobovkin