Add RegisterIgnoreAttribute to recognize external ignore attributes - #47
Closed
Yinmany wants to merge 1 commit into
Closed
Add RegisterIgnoreAttribute to recognize external ignore attributes#47Yinmany wants to merge 1 commit into
Yinmany wants to merge 1 commit into
Conversation
Owner
|
Hey, thanks for the contribution. I understand the reasoning behing this and consider the need valid. However I don't like the implementation both from performance and ergonomics point of view. Please also disclose the usage of AI - it helps me double check for edge cases. |
Owner
|
Closes #46 |
Author
|
Thanks for the feedback. Here is the AI usage disclosure: |
Owner
|
superseded by #49 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Models often already carry framework-level ignore attributes
(
[JsonIgnore],[BsonIgnore],[NotMapped], ...). Today users must also add[FastClonerIgnore]to every such member. This adds a global registration API soFastCloner honors those attributes directly.
API