Skip to content

Add RegisterIgnoreAttribute to recognize external ignore attributes - #47

Closed
Yinmany wants to merge 1 commit into
lofcz:nextfrom
Yinmany:next
Closed

Add RegisterIgnoreAttribute to recognize external ignore attributes#47
Yinmany wants to merge 1 commit into
lofcz:nextfrom
Yinmany:next

Conversation

@Yinmany

@Yinmany Yinmany commented Jul 18, 2026

Copy link
Copy Markdown

Summary

Models often already carry framework-level ignore attributes
([JsonIgnore], [BsonIgnore], [NotMapped], ...). Today users must also add
[FastClonerIgnore] to every such member. This adds a global registration API so
FastCloner honors those attributes directly.

API

FastCloner.FastCloner.RegisterIgnoreAttribute<JsonIgnoreAttribute>();

@lofcz

lofcz commented Jul 20, 2026

Copy link
Copy Markdown
Owner

Hey, thanks for the contribution. I understand the reasoning behing this and consider the need valid. However I don't like the implementation both from performance and ergonomics point of view. Please also disclose the usage of AI - it helps me double check for edge cases.

@lofcz

lofcz commented Jul 20, 2026

Copy link
Copy Markdown
Owner

Closes #46

@Yinmany

Yinmany commented Jul 20, 2026

Copy link
Copy Markdown
Author

Thanks for the feedback. Here is the AI usage disclosure:
This PR was implemented end-to-end with Codex assistance (including unit tests), following my instruction to keep the approach as simple as possible. I have manually run the full test suite and verified the code logic.
Your concerns regarding performance and ergonomics are noted — happy to discuss further improvements.

@lofcz

lofcz commented Aug 18, 2026

Copy link
Copy Markdown
Owner

superseded by #49

@lofcz lofcz closed this Aug 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants