Skip to content

Conversation

LangQi99
Copy link

@LangQi99 LangQi99 commented Jun 1, 2025

写代码还是更喜欢暗色

light mode:

屏幕截图 2025-06-01 175914
image
image
屏幕截图 2025-06-01 175836

dark mode:
image
image
image
image

@luantran069
Copy link

Please apply it

@luantran069 luantran069 mentioned this pull request Jun 2, 2025
@loggerhead
Copy link
Owner

感谢贡献,样式上可能有点问题需要先解决一下才能合入:

  1. 首页按钮样式:
    image
  2. table 模式下的折叠按钮:
    image
  3. text 模式下的比较按钮:
    image

兼容性上也有两个点需要先评估一下:

  1. 部分硬编码的颜色值需要适配暗黑模式,比如:src/lib/editor/color.ts
  2. 有段时间没写 nextjs 了,不确定引入 <ClientOnly> 组件对加载速度有没有影响(SSR);

再次,感谢你的贡献~工作日实在没时间,我可能得周末才有时间仔细的 review 然后处理 merge 了。


function ThemeButton() {
const { theme, setTheme } = useTheme();
const [mounted, setMounted] = React.useState(false);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

此处 mounted 的作用是什么?

{/* TODO: support dark theme */}
<ThemeProvider defaultTheme="light" disableTransitionOnChange>
<NextIntlClientProvider messages={messages}>{children}</NextIntlClientProvider>
<ClientOnly>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

我需要测试一下对加载速度的影响,有段时间没写 nextjs 不太记得了

@Donovan-Ye
Copy link

感谢作者开发了这么棒的 json4u 项目!我非常喜欢它的设计和功能。但相对于网页版,我更希望有一个桌面端工具。

所以我基于json4u开发了一个tauri的桌面端应用,项目地址:https://github.com/Donovan-Ye/easyJSON
但因为时间和使用场景,我只包含了图表和对比功能,同时增加了一些额外功能,比如暗黑模式、以及全局快捷键打开并粘贴等。可以尝试一下~ @LangQi99

Thank you to the author for developing such a great json4u project! I really like its design and features. But compared to the web version, I would like to have a desktop tool more.

So I developed a desktop application based on json4u using tauri, project address: https://github.com/Donovan-Ye/easyJSON

But due to time and usage scenarios, I only included chart and comparison features, and also added some additional functions, such as dark mode, and global shortcuts to open and paste. Give it a try~ @LangQi99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants