Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test/networking and privacy #4

Open
wants to merge 7 commits into
base: master
Choose a base branch
from
Open

Conversation

romanzac
Copy link
Collaborator

PR Details

Set of tests to cover networking and privacy.

Issues reported:

@romanzac
Copy link
Collaborator Author

This PR would require to re-test once reliability issues from #3 are resolved.

@romanzac romanzac marked this pull request as ready for review February 21, 2025 08:03
@romanzac romanzac requested a review from fbarbu15 February 21, 2025 08:04
Copy link
Collaborator

@fbarbu15 fbarbu15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thasnks, approved with one comment

class TestNetworkingPrivacy(StepsDataAvailability):
main_nodes = []

@pytest.mark.parametrize("setup_2_node_cluster", [2], indirect=True)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should the param be 2? I saw that the default value is 2
subnet_size = 2

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original idea is to have 1024 as subnet size, assuming the two cluster members will get assigned repeatedly to multiple subnets and receive 1 replica per each subnet. I wanted to get high volume with 2 node only. I keep this open for now, because the v2 version of subnetworks-assignations which should behave the expected way is not used yet.

https://github.com/logos-co/nomos-node/blob/2d4afb56a9bff5dba85af5d63a51b26911eb589a/nomos-da/network/subnetworks-assignations/src/versions/v2.rs#L48

And the dispersal endpoint is not reliable to even send two messages repeatedly, and when I tried larger data sample I've got 100% failure rate.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I would like to have at the end is efficiency guarding test. Something which will allow some initial efficiency to pass, and check if future versions won't get worse.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants