Threaded IO datastore with minimal modifications #48
Conversation
|
Added some tests and a very ugly locking mechanism that we can hopefully refine. The good thing is that all tests pass and there are 0 changes to the api. |
Ok, nice. |
| result = newSeq[byte](self.len) | ||
| if self.len() > 0: | ||
| copyMem(addr result[0], unsafeAddr self[].buf[0], self.len) | ||
| copyMem(addr result[0], addr self[].buf[0], self.len) |
There was a problem hiding this comment.
Ah good! I was thinking about that this weekend.
There was a problem hiding this comment.
yeah, but maybe this should also be switched to baseAddr? Not sure.
There was a problem hiding this comment.
Or the other way around, switch baseAddr to addr?
There was a problem hiding this comment.
Imo, addr is probably safer, baseAddr does a straight up cast.
|
This logos-storage/logos-storage-nim#552 works now. |
No description provided.