Add openssl_verify_mode property #14
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -119,7 +119,8 @@ def register | |||
| :password => options.fetch("password", nil), | |||
| :authentication => options.fetch("authenticationType", nil), | |||
| :enable_starttls_auto => options.fetch("starttls", false), | |||
| :debug => options.fetch("debug", false) | |||
| :debug => options.fetch("debug", false), | |||
| :openssl_verify_mode => options.fetch("openssl_verify_mode", 'peer') | |||
There was a problem hiding this comment.
I wonder what happen when TLS/SSL is not enabled if we setup this option like this ? can you test that?
|
Thanks a lot for your contribution @IldarMinaev, I just left you an open question I had. On the other side, do you mind adding test for this behaviour? I try to encourage to have as much as possible under test so we can track regressions, etc.. /cheers |
|
@jordansissel what do you think about having this option enabled by default? |
|
Jenkins standing by to test this. If you aren't a maintainer, you can ignore this comment. Someone with commit access, please review this and clear it for Jenkins to run; then say 'jenkins, test it'. |
|
please jenkins, test this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add openssl_verify_mode property