Redis supports failover through Sentinel #39
Conversation
|
Can you write the description of the change proposed in the PR? Looks like On Tuesday, September 6, 2016, Juntao [email protected] wrote:
|
|
hey @juntaozhang do you want to fix this or I make another PR for this feature? |
|
@jsvd I think this could be a great addition. Do you think that it could be merged, now? |
|
Are there any plans to merge this in, along with logstash-plugins/logstash-input-redis#50 too? |
|
+1 |
|
Hello @jsvd, if this PR doesn't seem good to you, don't hesitate to tell us, we can surely fix it! |
|
+1024, we want it! |
|
I guess that those logstash plugins are not a priority anymore. So I doubt it'll be merged some day... Saldy... |
| Redis.new(params) | ||
| end # def connect | ||
|
|
||
| # A string used to identify a Redis instance in log messages | ||
| def identity | ||
| if @sentinel_hosts | ||
| return "redis-sentinel://#{@password} #{$sentinel_hosts} #{@db} #{@data_type}:#{@key}" |
There was a problem hiding this comment.
should this be @sentinel_hosts instead?
| @@ -92,6 +92,10 @@ class LogStash::Outputs::Redis < LogStash::Outputs::Base | |||
| # Zero means to check on every event. | |||
| config :congestion_interval, :validate => :number, :default => 1 | |||
|
|
|||
| config :sentinel_hosts, :validate => :array | |||
There was a problem hiding this comment.
can you provide documentation for these settings in the docs/index.asciidoc file?
|
Any news on this? |
|
+1 |
Thanks for contributing to Logstash! If you haven't already signed our CLA, here's a handy link: https://www.elastic.co/contributor-agreement/