Fix broken api! description
#11
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, remove ruby 2.0 as that's already pretty old release.
FIPS forbits using MD5 at system level, therefore we need to use something else inside.
string. calling camelize on a namespaced controller will result in Api::Mycontroller instead of Api::MyController
There seems to be some issue with ordering when testing the swagger results.
…e apipie documentation
…l_spec moved "match_field_structure" matcher into swagger_dsl_spec (the only spec using it) all specs pass
Before this patch, we only supported updating nested hashes. For example
param :user, Hash do
param :login, String
end
and
param :user, Hash do
param :oauth, String
end
has been merged properly. However when merging top-level params, such as
param :login, String
and
param :oauth, String
no changes were propagated.
In some Ruby implementations, we couldn't rely on specific order in the hash. The new matcher implementation doesn't rely on the order.
This fixes an issue when a validator includes a & that needs to be escaped in HTML.
It seems bundler is missing in ruby 2.2.10 image.
The number validator was missing and the decimal and array validator descriptions were mixed up.
+ remove some older rails versions to reduce the test matrix
- Since Rails constant loading looks in Rails eager_load and autoload paths, it's possible for files outside of api_controllers_matcher to be loaded. - Files that do not define an expected constant will cause a NameError to be raised. This was most commonly encountered with files in the concerns/ directory, which caused a NameError for a missing "Concerns::<name>" constant. This makes use of ActiveSupport::Dependencies::Loadable#require_dependency to explicitly load the file and its constants in a way that cooperates with Rails constant loading and unloading. https://guides.rubyonrails.org/autoloading_and_reloading_constants.html#require-dependency https://api.rubyonrails.org/classes/ActiveSupport/Dependencies/Loadable.html#method-i-require_dependency Fixes Apipie#347.
Haniyya
reviewed
Nov 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the problem that the API descriptions using
api!method does not appear in the auto-generated documentation.Preserving what's done in Apipie#527 fixes the problem.