icon: Rework icons to make use of the IconNamed trait
#1640
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes use of the
IconNamedtrait and a blanked implementation to convert anything that implements this to anIcon.This allows for easily defined custom versions of
IconName, while minimally changing existing code (essentially only if you previously made use of the.path()method on theIconNameenum; this now requires an import of theIconNamedtrait).Example
If you want to directly "render" a custom
IconNameyou must implement theRenderOncetrait and deriveIntoElementon theIconName.Overall I think is an improvement to the existing way to do custom
IconNameimplementations.I am unsure if this change should also be reflected in the documentation on the section with "Icons & Assets", though I personally think it would make sense to highlight this way to do custom versions of
IconNameas it is considerably less involved than the current approach.Closes #1627.