feat(auth): log token-less request rejections - #140
Merged
Conversation
mcp_auth_layer rejects a token-less request on AuthMode::Required (main/root/v2 endpoints) with a 401, before the request ever reaches a #[tool] method — so it never showed up in our own logs at all, only in client-observed error metrics. Confirmed this blind spot pulling a full week of production logs: a tool (business_segments) with real traffic and a nonzero client-observed error rate had zero matching entries in our own logs, consistent with rejections happening at this layer. Logs the request path, restricted-endpoint version (if any), and User-Agent — no token to log in this branch, since the absence of one is exactly why the request was rejected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mcp_auth_layerrejects a token-less request onAuthMode::Required(main/root/v2endpoints) with a 401, before the request ever reaches a#[tool]method — so it never showed up in our own logs at all, only in client-observed error metrics.Confirmed this blind spot by pulling a full week of production logs: a tool (
business_segments) with real traffic and a nonzero client-observed error rate had zero matching entries in our own logs, consistent with rejections happening at this layer before any of our tool-level logging runs.Logs the request path, restricted-endpoint version (if any), and
User-Agent— no token to log in this branch, since the absence of one is exactly why the request was rejected.Test plan
cargo buildcleancargo +nightly fmt --checkcleancargo clippy --all-features --all-targets -- -D warningscleancargo test— 229 passed, 0 failed (2 new tests: the 401+WWW-Authenticate response, and that the rejection is actually logged with path/user-agent)