Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vanilla js counter #139

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update vanilla js counter #139

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
807c1da
Updated the Vanilla JS extension example to work by removing onclick …
alex-christiansen Jan 20, 2025
b7a7aab
Add @babel/plugin-proposal-class-properties to devDependencies
alex-christiansen Jan 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions vanilla/counter/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@
"devDependencies": {
"@babel/cli": "7.17.6",
"@babel/core": "7.22.1",
"@babel/plugin-proposal-class-properties": "^7.18.6",
"@babel/plugin-proposal-object-rest-spread": "^7.12.1",
"@babel/plugin-transform-runtime": "7.22.4",
"@babel/preset-env": "7.22.4",
Expand Down
34 changes: 29 additions & 5 deletions vanilla/counter/src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,13 +25,15 @@
import {
connectExtensionHost,
LookerExtensionSDK40,
} from '@looker/extension-sdk'
} from '@looker/extension-sdk';

;(async () => {
(async () => {
const extensionSdk = await connectExtensionHost()
const sdk40 = LookerExtensionSDK40.createClient(extensionSdk)
const result = await sdk40.me()
const name = result.ok ? result.value.display_name : 'Unknown'

// Write the HTML content
document.write(`
<style>
body {
Expand Down Expand Up @@ -59,10 +61,32 @@ import {
<h1>Looker Counter Extension</h1>
<h2>Welcome ${name}</h2>
<h3>This number will increase by one upon every click:</h3>
<div class="butt" onclick="event.target.innerHTML = +event.target.innerHTML + (event.shiftKey ? -1 : 1); event.preventDefault
()">0</div>
<div class="butt" id="counterButton">0</div>
<h3>I hope you had fun with this Looker extension.</h3>
<img width="200" src="https://docs.looker.com/assets/site_images/looker-logo.svg" />
</div>
`)
`);

// Set up the click handler directly (without waiting for DOMContentLoaded)
const counterButton = document.getElementById('counterButton');

if (!counterButton) {
console.error('Counter button not found!')
return
} else {
console.log('Counter button found:', counterButton)
}

counterButton.addEventListener('click', (event) => {
console.log('Button clicked!')
console.log('Current counter value:', counterButton.innerHTML)

// Update the counter value
counterButton.innerHTML = +counterButton.innerHTML + (event.shiftKey ? -1 : 1)

console.log('Updated counter value:', counterButton.innerHTML)
event.preventDefault()
});


})()