fix: add generated property to model properties #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aaqilniz
force-pushed
the
fix/return-generated
branch
2 times, most recently
from
f6248d4 to
ba16681
Compare
Signed-off-by: Muhammad Aaqil <[email protected]>
aaqilniz
force-pushed
the
fix/return-generated
branch
from
ba16681 to
f6380de
Compare
aaqilniz
requested review from
dhmlau,
achrinza and
marioestradarosa
as code owners
|
Hi, @achrinza. Can you please have a look at the PR? |
dhmlau
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lb4 discovergenerates buggy code due to the Postgres connector not returning thegeneratedproperty for columns whether they are generated or not. This PR fixes that.Checklist
npm testpasses on your machine