fix: Update SA tools.

Now that doctrine/persistence#213 has been released in 2.3.0.
loophp · Jan 9, 2022 · 4b483b9 · 4b483b9
1 parent 85a6584
commit 4b483b9
Show file tree

Hide file tree

Showing 6 changed files with 5 additions and 53 deletions.
diff --git a/phpstan-doctrine-bug.neon b/phpstan-doctrine-bug.neon
diff --git a/phpstan.neon.dist b/phpstan.neon.dist
diff --git a/psalm-baseline.xml b/psalm-baseline.xml
diff --git a/psalm.xml b/psalm.xml
@@ -3,7 +3,6 @@
     xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
     xmlns="https://getpsalm.org/schema/config"
     xsi:schemaLocation="https://getpsalm.org/schema/config vendor/vimeo/psalm/config.xsd"
-    errorBaseline="psalm-baseline.xml"
 >
     <projectFiles>
         <directory name="src" />

diff --git a/src/MonadicRepositoryFactory.php b/src/MonadicRepositoryFactory.php
@@ -30,20 +30,6 @@ public function fromEntity(string $entityClass): MonadicRepositoryInterface
 
     public function fromRepository(ObjectRepository $objectRepository): MonadicRepositoryInterface
     {
-        return $this->fromEntity($this->getEntityClass($objectRepository));
-    }
-
-    /**
-     * @template R
-     *
-     * @param ObjectRepository<R> $objectRepository
-     *
-     * @return class-string<R>
-     *
-     * @see https://github.com/doctrine/persistence/pull/213
-     */
-    private function getEntityClass(ObjectRepository $objectRepository): string
-    {
-        return $objectRepository->getClassName();
+        return $this->fromEntity($objectRepository->getClassName());
     }
 }
diff --git a/tests/unit/MonadicRepositoryHelperTest.php b/tests/unit/MonadicRepositoryHelperTest.php
@@ -249,15 +249,15 @@ static function (CustomEntity $customEntity): string {
             ->eitherFind($repository->reveal(), 3)
             ->bind(
                 static function (CustomEntity $customEntity): Either {
-                return ('' === $customEntity->getTitle())
+                    return ('' === $customEntity->getTitle())
                     ? Either::left(new Exception('Empty title'))
                     : Either::right($customEntity);
-            }
+                }
             )
             ->map(
                 static function (CustomEntity $customEntity): string {
-                return sprintf('%s%s', $customEntity->getTitle(), $customEntity->getTitle());
-            }
+                    return sprintf('%s%s', $customEntity->getTitle(), $customEntity->getTitle());
+                }
             )
             ->eval(
                 static fn (Throwable $i): string => $i->getMessage(),