fix: correct workflow node fields to match spec - #16
Merged
Conversation
nalanj
approved these changes
Jul 24, 2026
- AddToListTrigger nodes now decode mailingListId (was wrong tag / missing on the full node) - full SendEmailAction node now decodes emailMessageId - drop invalid "s" timer unit (spec enum is m/h/d) - marshalDiscriminated returns an error instead of panicking on a nil variant
notnmeyer
force-pushed
the
fix/workflow-node-fields
branch
from
July 24, 2026 17:21
572d29a to
2836cd0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
poking at the cli and i found a few inconsistencies i added in #13.
mailingList→mailingListId) and the full node was missing the field entirely, so GetWorkflow / GetWorkflowNode silently returned nothing. renamedMailingList string→MailingListID *string(a breaking change) and added it to the full node.emailMessageId— the comment claiming only the simplified variant had it was just wrong. added it.WorkflowTimerUnitSeconds— "s" isn't a valid unit, the api enum is m/h/d. source-breaking on that const, but it never actually worked.