fix: pass DiffEvent to onPush #609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zxch3n
requested changes
Jan 6, 2025
| @@ -2699,18 +2699,24 @@ impl UndoManager { | |||
|
|
|||
| /// Set the listener for push events. | |||
| /// The listener will be called when a new undo/redo item is pushed into the stack. | |||
| pub fn set_on_push(&mut self, on_push: Option<OnPush>) { | |||
There was a problem hiding this comment.
Users should be able to remove the on_push listener
| } | ||
|
|
||
| /// Set the listener for pop events. | ||
| /// The listener will be called when an undo/redo item is popped from the stack. | ||
| pub fn set_on_pop(&mut self, on_pop: Option<OnPop>) { |
zxch3n
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.