Completely redesigned all menus, fixed crashers due to new PlaylistEn…

…try structure, validated menu items, added menu entry for fading, synthesized playbackStatus, updated KnownIssues

Application/PlaybackController.h

@@ -38,6 +38,8 @@
 	AudioScrobbler *scrobbler;
  }
 
+@property int playbackStatus;
+
 - (IBAction)toggleShowTimeRemaining:(id)sender;
 - (IBAction)changeVolume:(id)sender;
 - (IBAction)volumeDown:(id)sender;
@@ -61,7 +63,7 @@
 - (void)seekForward:(double)sender;
 - (IBAction)eventSeekBackward:(id)sender;
 - (void)seekBackward:(double)amount;
-- (IBAction)fade:(id)sender withTime:(double)time;
+- (IBAction)fade:(id)sender;
 
 - (void)initDefaults;
 - (void)audioFadeDown:(NSTimer *)audioTimer;

Application/PlaybackController.m

@@ -11,6 +11,7 @@ @implementation PlaybackController
 
 #define DEFAULT_SEEK 10
 
+@synthesize playbackStatus;
 
 - (id)init
 {
@@ -290,6 +291,7 @@ - (void)audioFadeDown:(NSTimer *)audioTimer
 		[audioPlayer setVolume:originalVolume];
 		[volumeSlider setDoubleValue: logarithmicToLinear(originalVolume)];
 		[audioTimer invalidate];
+		playbackStatus = kCogStatusPaused;
 	}
 
 }
@@ -313,12 +315,15 @@ - (void)audioFadeUp:(NSTimer *)audioTimer
 	{
 		[volumeSlider setDoubleValue: logarithmicToLinear(originalVolume)];
 		[audioTimer invalidate];
+		playbackStatus = kCogStatusPlaying;
 	}
 
 }
 
-- (IBAction)fade:(id)sender withTime:(double)time
+- (IBAction)fade:(id)sender
 {
+	double time = 0.1;
+
 	// we can not allow multiple fade timers to be registered
 	if (playbackStatus == kCogStatusFading)
 		return;
@@ -351,7 +356,7 @@ - (IBAction)skipToNextAlbum:(id)sender
 {
     BOOL found = NO;
 
-	NSNumber *index = (NSNumber *)[[playlistController currentEntry] index];
+	int index = [[playlistController currentEntry] index];
 	NSString *origAlbum = [[playlistController currentEntry] album];
 
 	int i;
@@ -361,10 +366,9 @@ - (IBAction)skipToNextAlbum:(id)sender
 
 	for (i = 1; i < [[playlistController arrangedObjects] count]; i++)
 	{
-		pe = [playlistController entryAtIndex:[index intValue] + i];
-		if (pe == nil) {
+		pe = [playlistController entryAtIndex:index + i];
+		if (pe == nil) 
 			break;
-		}
 
 		curAlbum = [pe album];
 
@@ -385,7 +389,7 @@ - (IBAction)skipToNextAlbum:(id)sender
 
 	if (found)
 	{
-		[self playEntryAtIndex:i + [index intValue]];
+		[self playEntryAtIndex:i + index];
 	}
 }
 
@@ -394,7 +398,7 @@ - (IBAction)skipToPreviousAlbum:(id)sender
 	BOOL found = NO;
 	BOOL foundAlbum = NO;
 
-	NSNumber *index = (NSNumber *)[[playlistController currentEntry] index];
+	int index = [[playlistController currentEntry] index];
 	NSString *origAlbum = [[playlistController currentEntry] album];
 	NSString *curAlbum;
 
@@ -404,10 +408,10 @@ - (IBAction)skipToPreviousAlbum:(id)sender
 
 	for (i = 1; i < [[playlistController arrangedObjects] count]; i++)
 	{
-		pe = [playlistController entryAtIndex:[index intValue] - i];
-		if (pe == nil) {
+		pe = [playlistController entryAtIndex:index - i];
+		if (pe == nil) 
 			break;
-		}
+
 		curAlbum = [pe album];
 		if (curAlbum == nil)
 		{
@@ -437,7 +441,7 @@ - (IBAction)skipToPreviousAlbum:(id)sender
 	{
 		if (foundAlbum == YES)
 			i--;
-		[self playEntryAtIndex:[index intValue] - i];
+		[self playEntryAtIndex:index - i];
 	}
 }
 
@@ -571,10 +575,10 @@ -(BOOL)validateMenuItem:(NSMenuItem*)menuItem
 {
 	SEL action = [menuItem action];
 
-	if (action == @selector(seekBackward:) && (playbackStatus == kCogStatusStopped))
+	if (action == @selector(eventSeekBackward:) && (playbackStatus == kCogStatusStopped))
 		return NO;
 
-	if (action == @selector(seekForward:) && (playbackStatus == kCogStatusStopped))
+	if (action == @selector(eventSeekForward:) && (playbackStatus == kCogStatusStopped))
 		return NO;
 
 	if (action == @selector(stop:) && (playbackStatus == kCogStatusStopped))