Bug Fix: Set seek position when resuming paused

And a minor reoder of seek time reset code. Signed-off-by: Christopher Snowhill <[email protected]>
losnoco · Feb 16, 2025 · dd5be9b · dd5be9b
1 parent b8698ea
commit dd5be9b
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 3 deletions.
diff --git a/Application/PlaybackController.m b/Application/PlaybackController.m
@@ -878,6 +878,15 @@ - (void)audioPlayer:(AudioPlayer *)player reportPlayCountForTrack:(id)userInfo {
 	}
 }
 
+- (void)audioPlayer:(AudioPlayer *)player updatePosition:(id)userInfo {
+	if(userInfo) {
+		PlaylistEntry *pe = (PlaylistEntry *)userInfo;
+		if([pe current]) {
+			[self updatePosition:userInfo];
+		}
+	}
+}
+
 - (void)audioPlayer:(AudioPlayer *)player setError:(NSNumber *)status toTrack:(id)userInfo {
 	PlaylistEntry *pe = (PlaylistEntry *)userInfo;
 	[pe setError:[status boolValue]];

diff --git a/Audio/AudioPlayer.h b/Audio/AudioPlayer.h
@@ -138,5 +138,6 @@
 - (void)audioPlayer:(AudioPlayer *)player restartPlaybackAtCurrentPosition:(id)userInfo;
 - (void)audioPlayer:(AudioPlayer *)player pushInfo:(NSDictionary *)info toTrack:(id)userInfo;
 - (void)audioPlayer:(AudioPlayer *)player reportPlayCountForTrack:(id)userInfo;
+- (void)audioPlayer:(AudioPlayer *)player updatePosition:(id)userInfo;
 - (void)audioPlayer:(AudioPlayer *)player setError:(NSNumber *)status toTrack:(id)userInfo;
 @end
diff --git a/Audio/AudioPlayer.m b/Audio/AudioPlayer.m
@@ -131,8 +131,12 @@ - (void)play:(NSURL *)url withUserInfo:(id)userInfo withRGInfo:(NSDictionary *)r
 
 	[bufferChain launchThreads];
 
-	if(paused)
+	if(paused) {
 		[self setPlaybackStatus:CogStatusPaused waitUntilDone:YES];
+		if(time > 0.0) {
+			[self updatePosition:userInfo];
+		}
+	}
 }
 
 - (void)stop {
@@ -247,6 +251,10 @@ - (void)restartPlaybackAtCurrentPosition {
 	[self sendDelegateMethod:@selector(audioPlayer:restartPlaybackAtCurrentPosition:) withObject:previousUserInfo waitUntilDone:NO];
 }
 
+- (void)updatePosition:(id)userInfo {
+	[self sendDelegateMethod:@selector(audioPlayer:updatePosition:) withObject:userInfo waitUntilDone:NO];
+}
+
 - (void)pushInfo:(NSDictionary *)info toTrack:(id)userInfo {
 	[self sendDelegateMethod:@selector(audioPlayer:pushInfo:toTrack:) withObject:info withObject:userInfo waitUntilDone:NO];
 }

diff --git a/Audio/Chain/InputNode.m b/Audio/Chain/InputNode.m
@@ -164,24 +164,24 @@ - (void)process {
 			[bufferChain setVolume:0.0];
 
 			ConverterNode *converter = [bufferChain converter];
-			VisualizationNode *visualization = [bufferChain visualization];
 			DSPRubberbandNode *rubberband = [bufferChain rubberband];
 			DSPFSurroundNode *fsurround = [bufferChain fsurround];
 			DSPEqualizerNode *equalizer = [bufferChain equalizer];
 			DSPHRTFNode *hrtf = [bufferChain hrtf];
 			DSPDownmixNode *downmix = [bufferChain downmix];
+			VisualizationNode *visualization = [bufferChain visualization];
 			DLog(@"SEEKING! Resetting Buffer");
 
 			// This resets the converter's buffer
 			[self resetBuffer];
 			[converter resetBuffer];
 			[converter inputFormatDidChange:[bufferChain inputFormat] inputConfig:[bufferChain inputConfig]];
-			[visualization resetBuffer];
 			[rubberband resetBuffer];
 			[fsurround resetBuffer];
 			[equalizer resetBuffer];
 			[hrtf resetBuffer];
 			[downmix resetBuffer];
+			[visualization resetBuffer];
 
 			DLog(@"Reset buffer!");