Equalizer: Instances of GraphicEQ AU are now relinquished to the main…

… thread for destruction instead of being destroyed by the Core Audio Output shutdown

Application/PlaybackController.m

@@ -576,7 +576,7 @@ - (IBAction)volumeUp:(id)sender
 	[[NSUserDefaults standardUserDefaults] setDouble:[audioPlayer volume] forKey:@"volume"];
 }
 
-- (void)showStubEq
+- (void)eqAlloc
 {
     // Show a stopped equalizer as a stub
     OSStatus err;
@@ -602,15 +602,13 @@ - (void)showStubEq
         return;
 
     AudioUnitInitialize(_eq);
-
-    _eqStubbed = YES;
 }
 
-- (void)hideStubEq
+- (void)eqDealloc
 {
     AudioUnitUninitialize(_eq);
     AudioComponentInstanceDispose(_eq);
-    _eq = NULL;
+    _eq = nil;
     _eqStubbed = NO;
 }
 
@@ -625,7 +623,7 @@ - (IBAction)showEq:(id)sender
     }
     else
     {
-        [self showStubEq];
+        [self eqAlloc];
         _eqWasOpen = YES;
         [self audioPlayer:nil displayEqualizer:_eq];
         [_equi bringToFront];
@@ -655,10 +653,8 @@ - (void)audioPlayer:(AudioPlayer *)player displayEqualizer:(AudioUnit)eq
 
         CFPreferencesAppSynchronize(kCFPreferencesCurrentApplication);
 
-        if (_eqStubbed)
-        {
-            [self hideStubEq];
-        }
+        // Caller relinquishes EQ to us
+        [self eqDealloc];
     }
 
     _eq = eq;
@@ -728,9 +724,9 @@ - (void)audioPlayer:(AudioPlayer *)player removeEqualizer:(AudioUnit)eq
         {
             _eqWasOpen = [_equi isOpen];
         }
-    
+
         _equi = nil;
-        _eq = nil;
+        [self eqDealloc];
 
         if (_eqWasOpen)
         {

Audio/Output/OutputCoreAudio.m

@@ -767,9 +767,8 @@ - (void)stop
     }
     if (_eq)
     {
+        // This takes the EQ and frees it after disposing of any present UIs
         [outputController endEqualizer:_eq];
-        AudioUnitUninitialize(_eq);
-        AudioComponentInstanceDispose(_eq);
         _eq = NULL;
     }
 #ifdef OUTPUT_LOG