Skip to content

[Plan Deliverables Must Exist] Enforce plan deliverable review gates#289

Merged
lossyrob merged 3 commits intomainfrom
fix/282-plan-deliverables-review-gaps
Mar 17, 2026
Merged

[Plan Deliverables Must Exist] Enforce plan deliverable review gates#289
lossyrob merged 3 commits intomainfrom
fix/282-plan-deliverables-review-gaps

Conversation

@lossyrob
Copy link
Owner

@lossyrob lossyrob commented Mar 12, 2026

Closes #282

Summary

  • make paw-implement verify current-phase Changes Required deliverables before marking a phase complete
  • make paw-impl-review compare planned deliverables against actual repo state and block missing or empty planned outputs
  • make paw-final-review and the implementation spec treat missing planned deliverables as substantive review findings

Testing

  • ./scripts/lint-prompting.sh skills/paw-implement/SKILL.md
  • ./scripts/lint-prompting.sh skills/paw-impl-review/SKILL.md
  • ./scripts/lint-prompting.sh skills/paw-final-review/SKILL.md
  • npm run lint
  • npm run compile
  • cd tests/integration && npx tsx --test tests/skills/plan-deliverable-guardrails.test.ts
  • cd tests/integration && npx tsc --noEmit -p tsconfig.json
  • docs build could not run locally because .venv/bin/activate was not present in this worktree

Artifacts

Reviewer Notes

  • focus on the deliverable-contract language across paw-implement, paw-impl-review, and paw-final-review
  • the new regression test is offline-only and locks the prompt/spec contract in place

🐾 Generated with PAW

lossyrob and others added 3 commits March 12, 2026 13:18
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@lossyrob lossyrob merged commit 25cb115 into main Mar 17, 2026
1 check passed
@lossyrob lossyrob deleted the fix/282-plan-deliverables-review-gaps branch March 17, 2026 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PAW: Impl-review and final-review fail to catch missing plan deliverables

1 participant