Formal BBox struct #377
Open
Formal BBox struct #377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamin051000
force-pushed
the
formalize-bbox
branch
3 times, most recently
from
fabd9d0 to
4e65ed6
Compare
benjamin051000
force-pushed
the
formalize-bbox
branch
2 times, most recently
from
0faf517 to
aa7a51d
Compare
|
Blocked on #378 |
benjamin051000
force-pushed
the
formalize-bbox
branch
from
aa7a51d to
4776f60
Compare
benjamin051000
commented
Feb 22, 2025
| pub fn from_str(s: &str) -> Result<Self, String> { | ||
| let [min_lat, min_lng, max_lat, max_lng]: [f64; 4] = s | ||
| .split(',') | ||
| .map(|e| e.parse().unwrap()) |
There was a problem hiding this comment.
Should this return an Err signifying parsing failure?
benjamin051000
commented
Feb 22, 2025
src/bbox.rs
Outdated
| .map(|e| e.parse().unwrap()) | ||
| .collect::<Vec<_>>() | ||
| .try_into() | ||
| .unwrap(); |
There was a problem hiding this comment.
Should this return an Err? What cases will the try_into fail?
benjamin051000
force-pushed
the
formalize-bbox
branch
from
4776f60 to
a6310f5
Compare
benjamin051000
commented
Feb 22, 2025
benjamin051000
force-pushed
the
formalize-bbox
branch
from
a6310f5 to
ad642c9
Compare
benjamin051000
commented
Feb 22, 2025
benjamin051000
force-pushed
the
formalize-bbox
branch
2 times, most recently
from
c4a0f11 to
f705619
Compare
`BBox` represents a *valid* bounding box. It's only possible to have a BBox object that's valid.
benjamin051000
force-pushed
the
formalize-bbox
branch
from
f705619 to
cbf8c53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need a more standardized way to represent bounding boxes, as we kind of just throw the string around and parse it into the four corresponding values when we need to.
Fixes #375
To Do