-
Notifications
You must be signed in to change notification settings - Fork 76
Improve typehint #77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Improve typehint #77
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,30 @@ | ||
import unittest | ||
|
||
import marshmallow | ||
|
||
import marshmallow_dataclass | ||
|
||
|
||
class MyBaseSchema(marshmallow.Schema): | ||
pass | ||
|
||
|
||
class A: | ||
a: int | ||
|
||
|
||
# Top-level so that this is checked by mypy | ||
schema_with_base: MyBaseSchema = marshmallow_dataclass.class_schema( | ||
A, base_schema=MyBaseSchema | ||
)() | ||
|
||
schema_without_base: marshmallow.Schema = marshmallow_dataclass.class_schema(A)() | ||
|
||
|
||
# Regression test for https://github.com/lovasoa/marshmallow_dataclass/pull/77 | ||
class TestSchemaType(unittest.TestCase): | ||
def test_custom_basechema_type(self): | ||
self.assertIsInstance(schema_with_base, MyBaseSchema) | ||
|
||
def test_no_basechema_type(self): | ||
self.assertIsInstance(schema_without_base, marshmallow.Schema) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this annotation correct though ? The object returned by this function is a class that inherits from T_SchemaType, not T_SchemaType itself...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This function should return the same type that sanded throw
base_schema
. Ifbase_schema
is None then return default type.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I understand the problem with the two different overloads for this function. However, I don't think the type annotation you added is correct. The type of base_schema and the output type of the function are not the same.