-
Notifications
You must be signed in to change notification settings - Fork 666
Bring out debug_mode_o port #2306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
rishabhmitra-adi
wants to merge
1
commit into
lowRISC:master
Choose a base branch
from
rishabhmitra-adi:debug_mode_o_port_bringout
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -100,7 +100,8 @@ module ibex_top import ibex_pkg::*; #( | |
| output logic scramble_req_o, | ||
|
|
||
| // Debug Interface | ||
| input logic debug_req_i, | ||
| input logic debug_req_i, // Request to Core to enter debug mode | ||
| output logic debug_mode_o, // Indicates that the core has entered debug mode | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You would need to add this anywhere where ibex_top is instantiated as well. |
||
| output crash_dump_t crash_dump_o, | ||
| output logic double_fault_seen_o, | ||
|
|
||
|
|
@@ -385,6 +386,7 @@ module ibex_top import ibex_pkg::*; #( | |
| .irq_pending_o(irq_pending), | ||
|
|
||
| .debug_req_i, | ||
| .debug_mode_o(debug_mode_o), | ||
| .crash_dump_o, | ||
| .double_fault_seen_o, | ||
|
|
||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that debug mode is already exposed when RVFI is defined. Does that suffice in your use-case?