[DRAFT][opentitan, usbdev] Create a dummy usbdev block #164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Douglas Reis <[email protected]>
rivos-eblot
reviewed
Sep 2, 2025
rivos-eblot
reviewed
Sep 2, 2025
| @@ -98,6 +98,7 @@ config OT_EARLGREY | |||
| select OT_SRAM_CTRL | |||
| select OT_TIMER | |||
| select OT_UART | |||
| select OT_USBDEV | |||
There was a problem hiding this comment.
maybe OT_USB_DEVICE for consistency with OT_SPI_DEVICE (as well in filenames and symbols)?
There was a problem hiding this comment.
It seems to me that almost all are named according to the IP name (e.g. SRAM_CTRL, LC_CTRL, even SPI_DEVICE)? Therefore USBDEV seems to be right choice here?
There was a problem hiding this comment.
Most of them, but not all of them (RV_*, for example).
I'm still looking for the rationale behing some naming (e.g. why [A-Z]+MGR but [A-Z]+_CTRL?) which make some signal naming a bit awkward.
Keep USBDEV for now if you think it is better.
rivos-eblot
reviewed
Sep 2, 2025
rivos-eblot
reviewed
Sep 2, 2025
| CharBackend chr; | ||
| }; | ||
|
|
||
| static void usbdev_update_irqs(OtUSBDEVState *s) |
|
@engdoreis has asked me to take over the USB block. I have created a new PR #180 since I can't edit this one |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.