Fix clippy warnings #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use copy_nonoverlapping instead when it makes sense
Merged
examples/pwm.rs
Outdated
| @@ -96,7 +96,7 @@ fn main() -> ! { | |||
| } | |||
|
|
|||
| for i in 0..3 { | |||
| let duty = (sin(duties[i] * 3.14159265f32 / 180f32) * 255f32) as u16; | |||
| let duty = (sin(duties[i] * 3.141_592_7_f32 / 180f32) * 255f32) as u16; | |||
There was a problem hiding this comment.
Changed value – was that intentional?
There was a problem hiding this comment.
Hmm, good catch. That's something that was done by cargo clippy --fix. I think it's because the value is parsed as a f32 then re-encoded, the binary representation of both is the same.
fn main() {
assert_eq!(3.14159265f32, 3.141_592_7_f32);
}does not panic.
There was a problem hiding this comment.
Oh, I overlooked that this is only the decimal part. Makes sense.
There was a problem hiding this comment.
I'll actually make this use f32::consts::PI.
robin-nitrokey
approved these changes
Jan 21, 2025
|
Hmm, and now I discover that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of #74