Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Development: Display more in-depth health information about the hermes service #10068

Merged
merged 14 commits into from
Feb 15, 2025

Conversation

PaRangger
Copy link
Contributor

@PaRangger PaRangger commented Dec 23, 2024

Checklist

General

Server

Motivation and Context

Currently, Artemis checks if Hermes is running by calling the base url and looking if it returns a 200 response code. While working, this does not provide a lot of information to the admins.

Description

I implemented a new /api/health api in the Hermes Repository that provides the information whether or not Hermes was able to connect to the APNS or to Firebase. Additionally, it returns the version number of Hermes. This information is displayed in the "details" section when viewing the service health in the admin panel.

Steps for Testing

Prerequisites:

  • 1 Artemis Admin (On TS3 your TUM Online Account should be admin)
  1. Log in to Artemis
  2. Navigate to Server Administration > Health in the navbar
  3. Check if the Hermes service is displayed as online
  4. Click the "Eye" icon to view the details
  5. Check if the additional info (firebase_up, apns_up and version) are displayed. (It should say "up" in 99% of cases.)

Testserver States

Note

These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Click on the badges to get to the test servers.







Review Progress

Code Review

  • Code Review 1
  • Code Review 2

Manual Tests

  • Test 1
  • Test 2

Screenshots

Bildschirmfoto 2024-12-23 um 14 05 30

Summary by CodeRabbit

  • New Features

    • Enhanced health checking mechanism for Hermes push notification service
    • Added support for retrieving detailed health status from a new endpoint
  • Bug Fixes

    • Improved service availability detection with fallback mechanism

@PaRangger PaRangger added feature server Pull requests that update Java code. (Added Automatically!) component:Notification small labels Dec 23, 2024
@PaRangger PaRangger self-assigned this Dec 23, 2024
@github-actions github-actions bot added the communication Pull requests that affect the corresponding module label Dec 23, 2024
Copy link

There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Dec 31, 2024
@PaRangger PaRangger removed the stale label Jan 2, 2025
Copy link

github-actions bot commented Jan 9, 2025

There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Jan 9, 2025
@PaRangger PaRangger removed the stale label Jan 10, 2025
Copy link
Contributor

@SimonEntholzer SimonEntholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code

@github-actions github-actions bot added deployment-error Added by deployment workflows if an error occured and removed deploy:artemis-test3 labels Jan 28, 2025
@PaRangger PaRangger removed the deployment-error Added by deployment workflows if an error occured label Feb 1, 2025
Copy link
Contributor

@cremertim cremertim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tested on ts3, works as described

@egekocabas
Copy link
Member

Removed the lock label as we have migrated to Helios for test server deployments. Please refer to the Helios deployment guide for instructions on deploying to test servers 👍🏻

@krusche krusche added this to the 7.10.1 milestone Feb 15, 2025
@krusche krusche merged commit c371d3f into develop Feb 15, 2025
26 of 30 checks passed
@krusche krusche deleted the feature/development/improve-hermes-health-indicator branch February 15, 2025 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
communication Pull requests that affect the corresponding module feature ready to merge server Pull requests that update Java code. (Added Automatically!) small
Projects
Status: Merged
Status: Done
Development

Successfully merging this pull request may close these issues.

8 participants