-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Development
: Remove Artemis Test Module
#10275
Draft
tobias-lippert
wants to merge
480
commits into
develop
Choose a base branch
from
chore/remove-artemis-test-module
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+3,658
−1,772
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/test/javascript/spec/component/code-editor/code-editor-file-browser.component.spec.ts # src/test/javascript/spec/component/exam-exercise-row-buttons/exam-exercise-row-buttons.component.spec.ts # src/test/javascript/spec/component/exam/manage/exercise-groups/exercise-groups.component.spec.ts # src/test/javascript/spec/component/exam/manage/exercise-groups/programming-exercise-group-cell.component.spec.ts # src/test/javascript/spec/component/exam/participate/exercises/file-upload-exam-submission.component.spec.ts # src/test/javascript/spec/component/exam/participate/exercises/modeling-exam-submission.component.spec.ts # src/test/javascript/spec/component/example-modeling/example-modeling-submission.component.spec.ts # src/test/javascript/spec/component/localci/build-queue/build-queue.component.spec.ts # src/test/javascript/spec/component/orion/orion-code-editor-instructor-and-editor-container.component.spec.ts # src/test/javascript/spec/component/plagiarism/plagiarism-case-verdict.component.spec.ts # src/test/javascript/spec/component/plagiarism/plagiarism-cases-instructor-view.component.spec.ts # src/test/javascript/spec/component/plagiarism/plagiarism-header.component.spec.ts # src/test/javascript/spec/component/programming-exercise/programming-exercise-configure-grading.component.spec.ts # src/test/javascript/spec/component/programming-exercise/programming-exercise.component.spec.ts # src/test/javascript/spec/component/shared/main.component.spec.ts # src/test/javascript/spec/component/text-submission-assessment/textblock-feedback-editor.component.spec.ts # src/test/javascript/spec/helpers/mocks/service/mock-programming-exercise.service.ts # src/test/javascript/spec/service/orion/orion-connector.service.spec.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
General
Client
Motivation and Context
We also need to remove the
ArtemisTestModule
that's the base for most of our client tests and replace it with a mechanism that doesn't rely on modulesDescription
Removed
ArtemisTestModule
and introduced atest-helper
that provides methods to import mock providers and to set up the locale /date when necessary.Steps for Testing
Code Review only.
Make sure the client tests pass.
Testserver States
You can manage test servers using Helios. Check environment statuses in the environment list. To deploy to a test server, go to the CI/CD page, find your PR or branch, and trigger the deployment.
Review Progress
Code Review
Test Coverage
only changed test files.