Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implement pipeline for processing test workflow results #341

Merged
merged 32 commits into from
Feb 17, 2025

Conversation

StefanNemeth
Copy link
Contributor

@StefanNemeth StefanNemeth commented Feb 4, 2025

I started looking into the implementation of our test case overview that we want to show within Helios in the near future for branches and PRs. Right now, we're only showing the checks/status of the workflow runs.

Objective

This PR will cover a first implementation of a test processing pipeline that will create TestSuite and corresponding TestCase entities based on one or multiple JUnit Report XML files that are uploaded as artifacts by a workflow run. Additionally, I want to display the results in a simple way within the branch and PR details view.

Current pipeline

  1. Artifact fetching
  • Retrieves workflow run artifacts via GitHub API (returns PagedIterator)
  • Looks for specifically named artifact ("Test Results")
  1. ZIP processing
  • Downloads and unpacks zip archive (using stream)
  • Searches for JUnit XML files within the archive
  1. Result parsing
  • Simple JUnit XML parsing using JAXB
  • Basic aggregation of totals (passed/failed/time)
  • Parsing test cases with type (error, failure, skipped, success) and message/stackTrace
  1. Persists all results to database

Conditions

  1. The label of at least one workflow is set to TEST
  2. The test workflow uploads an artifact called "JUnit Test Results" containing junit xml report files
  3. The test workflow is configured to be a member of a workflow group

Screenshot/Video

recording.mov

Additional changes

  • Fixed the weird spinning animation of the workflow run icons
  • Changed the environment scheduler to not run when the OpenAPI profile is active

Testing

I created a repository that contains two test workflows:

  • test-artemis.yml uploads the results of a full Artemis test with 1 failure
  • test.yml actually runs the tests of a Spring boot application, however there is just one test in there right now

In order to test it, you'll have to set REPOSITORY_NAME in your env variables to ege-test-org/test-junit-repo, let it sync, set the labels of test-artemis.yml, test.yml or both to "TEST" within the project settings, set up a webhook within ege-test-org/test-junit-repo and trigger a test run (just change a file and push to main).

Future Work

  • Extend supported parsers so we can also include client tests
  • Document usage for users (e.g. they will have to upload their results with a specific artifact name and set a workflow label)
  • Implement some kind of timeout for the processing of the tests + max values for the size of the artifact
  • Delete old test suites + cases or just old runs in general? We might need the data for detecting flaky tests.

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

checkstyle

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def' child has incorrect indentation level 8, expected level should be 4.

log.debug("Parsed {} test results. Persisting...", results.size());


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def' child has incorrect indentation level 8, expected level should be 4.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'block' child has incorrect indentation level 12, expected level should be 10.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'block' child has incorrect indentation level 12, expected level should be 10.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'block' child has incorrect indentation level 12, expected level should be 10.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'block' child has incorrect indentation level 12, expected level should be 10.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'block' child has incorrect indentation level 12, expected level should be 10.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'block' child has incorrect indentation level 12, expected level should be 10.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'block' child has incorrect indentation level 12, expected level should be 10.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'block' child has incorrect indentation level 12, expected level should be 10.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def' child has incorrect indentation level 8, expected level should be 4.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def rcurly' has incorrect indentation level 4, expected level should be 2.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 102).

private List<TestParserResult> processTestResultArtifact(GHArtifact artifact) throws IOException {


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def modifier' has incorrect indentation level 4, expected level should be 2.

private List<TestParserResult> processTestResultArtifact(GHArtifact artifact) throws IOException {


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def' child has incorrect indentation level 8, expected level should be 4.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'block' child has incorrect indentation level 12, expected level should be 10.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'try' has incorrect indentation level 12, expected level should be 10.

try (ZipInputStream zipInput = new ZipInputStream(stream)) {


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'try' child has incorrect indentation level 16, expected level should be 12.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'while' has incorrect indentation level 16, expected level should be 12.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'if' has incorrect indentation level 20, expected level should be 14.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'if' has incorrect indentation level 24, expected level should be 16.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'if' child has incorrect indentation level 28, expected level should be 18.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'if rcurly' has incorrect indentation level 24, expected level should be 16.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'if rcurly' has incorrect indentation level 20, expected level should be 14.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'while' child has incorrect indentation level 20, expected level should be 14.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'while rcurly' has incorrect indentation level 16, expected level should be 12.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'try rcurly' has incorrect indentation level 12, expected level should be 10.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'block' child has incorrect indentation level 12, expected level should be 10.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def rcurly' has incorrect indentation level 4, expected level should be 2.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'ctor def modifier' has incorrect indentation level 4, expected level should be 2.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'ctor def' child has incorrect indentation level 8, expected level should be 4.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'ctor def rcurly' has incorrect indentation level 4, expected level should be 2.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'ctor def modifier' has incorrect indentation level 4, expected level should be 2.

public TestResultException(String message, Throwable cause) {


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'ctor def' child has incorrect indentation level 8, expected level should be 4.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'ctor def rcurly' has incorrect indentation level 4, expected level should be 2.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def modifier' has incorrect indentation level 4, expected level should be 2.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def modifier' has incorrect indentation level 4, expected level should be 2.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.naming.AbbreviationAsWordInNameCheck> reported by reviewdog 🐶
Abbreviation in name 'JUnitParser' must contain no more than '1' consecutive capital letters.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'ctor def modifier' has incorrect indentation level 4, expected level should be 2.

public TestResultParseException(String message, Throwable cause) {


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'ctor def' child has incorrect indentation level 8, expected level should be 4.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'ctor def rcurly' has incorrect indentation level 4, expected level should be 2.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'compact ctor def modifier' has incorrect indentation level 4, expected level should be 2.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'if' has incorrect indentation level 8, expected level should be 4.

if (total < 0 || failures < 0 || errors < 0 || skipped < 0 || time < 0) {


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'if' child has incorrect indentation level 12, expected level should be 6.

throw new IllegalArgumentException("Negative values not allowed");


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'if rcurly' has incorrect indentation level 8, expected level should be 4.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'compact ctor def rcurly' has incorrect indentation level 4, expected level should be 2.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def modifier' has incorrect indentation level 4, expected level should be 2.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def' child has incorrect indentation level 8, expected level should be 4.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def rcurly' has incorrect indentation level 4, expected level should be 2.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'member def modifier' has incorrect indentation level 4, expected level should be 2.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'member def modifier' has incorrect indentation level 4, expected level should be 2.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'member def modifier' has incorrect indentation level 4, expected level should be 2.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'member def modifier' has incorrect indentation level 4, expected level should be 2.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'member def modifier' has incorrect indentation level 4, expected level should be 2.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'member def modifier' has incorrect indentation level 4, expected level should be 2.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'member def modifier' has incorrect indentation level 4, expected level should be 2.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.imports.CustomImportOrderCheck> reported by reviewdog 🐶
Wrong lexicographical order for 'org.springframework.web.bind.annotation.PathVariable' import. Should be before 'org.springframework.web.bind.annotation.RestController'.

import org.springframework.web.bind.annotation.PathVariable;


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.imports.CustomImportOrderCheck> reported by reviewdog 🐶
Wrong lexicographical order for 'org.springframework.http.ResponseEntity' import. Should be before 'org.springframework.web.bind.annotation.RestController'.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.imports.CustomImportOrderCheck> reported by reviewdog 🐶
Wrong lexicographical order for 'org.springframework.web.bind.annotation.GetMapping' import. Should be before 'org.springframework.web.bind.annotation.RestController'.

import org.springframework.web.bind.annotation.GetMapping;


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.imports.CustomImportOrderCheck> reported by reviewdog 🐶
Wrong lexicographical order for 'org.springframework.web.bind.annotation.RequestParam' import. Should be before 'org.springframework.web.bind.annotation.RestController'.

import org.springframework.web.bind.annotation.RequestParam;


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def modifier' has incorrect indentation level 4, expected level should be 2.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def' child has incorrect indentation level 8, expected level should be 4.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def rcurly' has incorrect indentation level 4, expected level should be 2.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def modifier' has incorrect indentation level 4, expected level should be 2.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 110).

public ResponseEntity<List<TestResult>> getTestResultsByBranchAndHeadCommit(@RequestParam String branch) {


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def' child has incorrect indentation level 8, expected level should be 4.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def rcurly' has incorrect indentation level 4, expected level should be 2.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.NonEmptyAtclauseDescriptionCheck> reported by reviewdog 🐶
At-clause should have a non-empty description.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.RequireEmptyLineBeforeBlockTagGroupCheck> reported by reviewdog 🐶
Javadoc tag '@param' should be preceded with an empty line.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck> reported by reviewdog 🐶
Unused @param tag for 'repoNameWithOwners'.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.NonEmptyAtclauseDescriptionCheck> reported by reviewdog 🐶
At-clause should have a non-empty description.

public PagedIterable<GHArtifact> getWorkflowRunArtifacts(long repoId, long workflowRunId) throws IOException {


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 112).

@egekocabas egekocabas linked an issue Feb 7, 2025 that may be closed by this pull request
Copy link

There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions.

@github-actions github-actions bot added the stale label Feb 12, 2025
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

checkstyle

🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def' child has incorrect indentation level 8, expected level should be 4.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'block' child has incorrect indentation level 12, expected level should be 10.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'block' child has incorrect indentation level 12, expected level should be 10.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'block' child has incorrect indentation level 12, expected level should be 10.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'block' child has incorrect indentation level 12, expected level should be 10.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'block' child has incorrect indentation level 12, expected level should be 10.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'block' child has incorrect indentation level 12, expected level should be 10.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'block' child has incorrect indentation level 12, expected level should be 10.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'block' child has incorrect indentation level 12, expected level should be 10.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def' child has incorrect indentation level 8, expected level should be 4.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def rcurly' has incorrect indentation level 4, expected level should be 2.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 102).

private List<TestParserResult> processTestResultArtifact(GHArtifact artifact) throws IOException {


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def modifier' has incorrect indentation level 4, expected level should be 2.

private List<TestParserResult> processTestResultArtifact(GHArtifact artifact) throws IOException {


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def' child has incorrect indentation level 8, expected level should be 4.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'block' child has incorrect indentation level 12, expected level should be 10.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'try' has incorrect indentation level 12, expected level should be 10.

try (ZipInputStream zipInput = new ZipInputStream(stream)) {


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'try' child has incorrect indentation level 16, expected level should be 12.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'while' has incorrect indentation level 16, expected level should be 12.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'if' has incorrect indentation level 20, expected level should be 14.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'if' has incorrect indentation level 24, expected level should be 16.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'if' child has incorrect indentation level 28, expected level should be 18.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'if rcurly' has incorrect indentation level 24, expected level should be 16.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'if rcurly' has incorrect indentation level 20, expected level should be 14.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'while' child has incorrect indentation level 20, expected level should be 14.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'while rcurly' has incorrect indentation level 16, expected level should be 12.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'try rcurly' has incorrect indentation level 12, expected level should be 10.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'block' child has incorrect indentation level 12, expected level should be 10.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def rcurly' has incorrect indentation level 4, expected level should be 2.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'ctor def modifier' has incorrect indentation level 4, expected level should be 2.

public TestResultParseException(String message, Throwable cause) {


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'ctor def' child has incorrect indentation level 8, expected level should be 4.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'ctor def rcurly' has incorrect indentation level 4, expected level should be 2.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.naming.AbbreviationAsWordInNameCheck> reported by reviewdog 🐶
Abbreviation in name 'JUnitParser' must contain no more than '1' consecutive capital letters.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def modifier' has incorrect indentation level 4, expected level should be 2.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def modifier' has incorrect indentation level 4, expected level should be 2.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'compact ctor def modifier' has incorrect indentation level 4, expected level should be 2.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'if' has incorrect indentation level 8, expected level should be 4.

if (total < 0 || failures < 0 || errors < 0 || skipped < 0 || time < 0) {


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'if' child has incorrect indentation level 12, expected level should be 6.

throw new IllegalArgumentException("Negative values not allowed");


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'if rcurly' has incorrect indentation level 8, expected level should be 4.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'compact ctor def rcurly' has incorrect indentation level 4, expected level should be 2.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def modifier' has incorrect indentation level 4, expected level should be 2.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def' child has incorrect indentation level 8, expected level should be 4.


🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def rcurly' has incorrect indentation level 4, expected level should be 2.

Copy link

codacy-production bot commented Feb 14, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for d85c5911 1.11%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (d85c591) Report Missing Report Missing Report Missing
Head commit (be33d0b) 5086 319 6.27%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#341) 270 3 1.11%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@github-actions github-actions bot added documentation Improvements or additions to documentation github-config notification-server size:XXL and removed size:L labels Feb 14, 2025
@github-actions github-actions bot added size:XL and removed documentation Improvements or additions to documentation github-config notification-server size:XXL labels Feb 15, 2025
@github-actions github-actions bot removed the stale label Feb 15, 2025
@github-actions github-actions bot added size:XXL and removed size:XL labels Feb 15, 2025
@StefanNemeth StefanNemeth marked this pull request as ready for review February 15, 2025 14:48
@StefanNemeth StefanNemeth requested a review from a team as a code owner February 15, 2025 14:48
Copy link
Contributor

@gbanu gbanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Tested it for the test repo, and it works perfectly! I think we can merge it, because it doesn't introduce any breaking changes, and if we encounter some issues with the Artemis just fix them later 👍

@StefanNemeth StefanNemeth merged commit 1c4b08b into staging Feb 17, 2025
12 checks passed
@StefanNemeth StefanNemeth deleted the feat/junit-parser branch February 17, 2025 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add information about failing/passing JUnit tests
2 participants