-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Implement pipeline for processing test workflow results #341
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
checkstyle
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def' child has incorrect indentation level 8, expected level should be 4.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultProcessor.java
Line 69 in 86660b2
log.debug("Parsed {} test results. Persisting...", results.size()); |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def' child has incorrect indentation level 8, expected level should be 4.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultProcessor.java
Line 71 in 86660b2
results.forEach(result -> { |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'block' child has incorrect indentation level 12, expected level should be 10.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultProcessor.java
Line 72 in 86660b2
final TestResult testResult = new TestResult(); |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'block' child has incorrect indentation level 12, expected level should be 10.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultProcessor.java
Line 73 in 86660b2
testResult.setWorkflowRun(workflowRun); |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'block' child has incorrect indentation level 12, expected level should be 10.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultProcessor.java
Line 74 in 86660b2
testResult.setTotal(result.total()); |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'block' child has incorrect indentation level 12, expected level should be 10.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultProcessor.java
Line 75 in 86660b2
testResult.setPassed(result.passed()); |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'block' child has incorrect indentation level 12, expected level should be 10.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultProcessor.java
Line 76 in 86660b2
testResult.setFailures(result.failures()); |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'block' child has incorrect indentation level 12, expected level should be 10.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultProcessor.java
Line 77 in 86660b2
testResult.setErrors(result.errors()); |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'block' child has incorrect indentation level 12, expected level should be 10.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultProcessor.java
Line 78 in 86660b2
testResult.setSkipped(result.skipped()); |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'block' child has incorrect indentation level 12, expected level should be 10.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultProcessor.java
Line 79 in 86660b2
testResultRepository.save(testResult); |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def' child has incorrect indentation level 8, expected level should be 4.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultProcessor.java
Line 82 in 86660b2
log.debug("Persisted test results"); |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def rcurly' has incorrect indentation level 4, expected level should be 2.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultProcessor.java
Line 83 in 86660b2
} |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 102).
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultProcessor.java
Line 85 in 86660b2
private List<TestParserResult> processTestResultArtifact(GHArtifact artifact) throws IOException { |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def modifier' has incorrect indentation level 4, expected level should be 2.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultProcessor.java
Line 85 in 86660b2
private List<TestParserResult> processTestResultArtifact(GHArtifact artifact) throws IOException { |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def' child has incorrect indentation level 8, expected level should be 4.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultProcessor.java
Line 87 in 86660b2
return artifact.download(stream -> { |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'block' child has incorrect indentation level 12, expected level should be 10.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultProcessor.java
Line 88 in 86660b2
List<TestParserResult> results = new ArrayList<>(); |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'try' has incorrect indentation level 12, expected level should be 10.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultProcessor.java
Line 90 in 86660b2
try (ZipInputStream zipInput = new ZipInputStream(stream)) { |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'try' child has incorrect indentation level 16, expected level should be 12.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultProcessor.java
Line 91 in 86660b2
ZipEntry entry; |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'while' has incorrect indentation level 16, expected level should be 12.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultProcessor.java
Line 93 in 86660b2
while ((entry = zipInput.getNextEntry()) != null) { |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'if' has incorrect indentation level 20, expected level should be 14.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultProcessor.java
Line 94 in 86660b2
if (!entry.isDirectory()) { |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'if' has incorrect indentation level 24, expected level should be 16.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultProcessor.java
Line 95 in 86660b2
if (this.junitParser.supports(entry.getName())) { |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'if' child has incorrect indentation level 28, expected level should be 18.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultProcessor.java
Line 96 in 86660b2
results.add(this.junitParser.parse(zipInput)); |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'if rcurly' has incorrect indentation level 24, expected level should be 16.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultProcessor.java
Line 97 in 86660b2
} |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'if rcurly' has incorrect indentation level 20, expected level should be 14.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultProcessor.java
Line 98 in 86660b2
} |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'while' child has incorrect indentation level 20, expected level should be 14.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultProcessor.java
Line 99 in 86660b2
zipInput.closeEntry(); |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'while rcurly' has incorrect indentation level 16, expected level should be 12.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultProcessor.java
Line 100 in 86660b2
} |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'try rcurly' has incorrect indentation level 12, expected level should be 10.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultProcessor.java
Line 101 in 86660b2
} |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'block' child has incorrect indentation level 12, expected level should be 10.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultProcessor.java
Line 103 in 86660b2
return results; |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def rcurly' has incorrect indentation level 4, expected level should be 2.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultProcessor.java
Line 105 in 86660b2
} |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'ctor def modifier' has incorrect indentation level 4, expected level should be 2.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultException.java
Line 4 in 86660b2
public TestResultException(String message) { |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'ctor def' child has incorrect indentation level 8, expected level should be 4.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultException.java
Line 5 in 86660b2
super(message); |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'ctor def rcurly' has incorrect indentation level 4, expected level should be 2.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultException.java
Line 6 in 86660b2
} |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'ctor def modifier' has incorrect indentation level 4, expected level should be 2.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultException.java
Line 8 in 86660b2
public TestResultException(String message, Throwable cause) { |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'ctor def' child has incorrect indentation level 8, expected level should be 4.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultException.java
Line 9 in 86660b2
super(message, cause); |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'ctor def rcurly' has incorrect indentation level 4, expected level should be 2.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultException.java
Line 10 in 86660b2
} |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def modifier' has incorrect indentation level 4, expected level should be 2.
Line 6 in 86660b2
TestParserResult parse(InputStream content); |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def modifier' has incorrect indentation level 4, expected level should be 2.
Line 8 in 86660b2
boolean supports(String artifactName); |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.naming.AbbreviationAsWordInNameCheck> reported by reviewdog 🐶
Abbreviation in name 'JUnitParser' must contain no more than '1' consecutive capital letters.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/parsers/JUnitParser.java
Line 14 in 86660b2
public class JUnitParser implements TestResultParser { |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'ctor def modifier' has incorrect indentation level 4, expected level should be 2.
Line 4 in 86660b2
public TestResultParseException(String message, Throwable cause) { |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'ctor def' child has incorrect indentation level 8, expected level should be 4.
Line 5 in 86660b2
super(message, cause); |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'ctor def rcurly' has incorrect indentation level 4, expected level should be 2.
Line 6 in 86660b2
} |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'compact ctor def modifier' has incorrect indentation level 4, expected level should be 2.
Line 4 in 86660b2
public TestParserResult { |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'if' has incorrect indentation level 8, expected level should be 4.
Line 5 in 86660b2
if (total < 0 || failures < 0 || errors < 0 || skipped < 0 || time < 0) { |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'if' child has incorrect indentation level 12, expected level should be 6.
Line 6 in 86660b2
throw new IllegalArgumentException("Negative values not allowed"); |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'if rcurly' has incorrect indentation level 8, expected level should be 4.
Line 7 in 86660b2
} |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'compact ctor def rcurly' has incorrect indentation level 4, expected level should be 2.
Line 8 in 86660b2
} |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def modifier' has incorrect indentation level 4, expected level should be 2.
Line 10 in 86660b2
public int passed() { |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def' child has incorrect indentation level 8, expected level should be 4.
Line 11 in 86660b2
return total - failures - errors - skipped; |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def rcurly' has incorrect indentation level 4, expected level should be 2.
Line 12 in 86660b2
} |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'member def modifier' has incorrect indentation level 4, expected level should be 2.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResult.java
Line 22 in 86660b2
@Id |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'member def modifier' has incorrect indentation level 4, expected level should be 2.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResult.java
Line 26 in 86660b2
@ManyToOne(optional = false) |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'member def modifier' has incorrect indentation level 4, expected level should be 2.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResult.java
Line 29 in 86660b2
@Min(0) |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'member def modifier' has incorrect indentation level 4, expected level should be 2.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResult.java
Line 33 in 86660b2
@Min(0) |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'member def modifier' has incorrect indentation level 4, expected level should be 2.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResult.java
Line 37 in 86660b2
@Min(0) |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'member def modifier' has incorrect indentation level 4, expected level should be 2.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResult.java
Line 41 in 86660b2
@Min(0) |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'member def modifier' has incorrect indentation level 4, expected level should be 2.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResult.java
Line 45 in 86660b2
@Min(0) |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.imports.CustomImportOrderCheck> reported by reviewdog 🐶
Wrong lexicographical order for 'org.springframework.web.bind.annotation.PathVariable' import. Should be before 'org.springframework.web.bind.annotation.RestController'.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultController.java
Line 8 in 86660b2
import org.springframework.web.bind.annotation.PathVariable; |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.imports.CustomImportOrderCheck> reported by reviewdog 🐶
Wrong lexicographical order for 'org.springframework.http.ResponseEntity' import. Should be before 'org.springframework.web.bind.annotation.RestController'.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultController.java
Line 9 in 86660b2
import org.springframework.http.ResponseEntity; |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.imports.CustomImportOrderCheck> reported by reviewdog 🐶
Wrong lexicographical order for 'org.springframework.web.bind.annotation.GetMapping' import. Should be before 'org.springframework.web.bind.annotation.RestController'.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultController.java
Line 10 in 86660b2
import org.springframework.web.bind.annotation.GetMapping; |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.imports.CustomImportOrderCheck> reported by reviewdog 🐶
Wrong lexicographical order for 'org.springframework.web.bind.annotation.RequestParam' import. Should be before 'org.springframework.web.bind.annotation.RestController'.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultController.java
Line 11 in 86660b2
import org.springframework.web.bind.annotation.RequestParam; |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def modifier' has incorrect indentation level 4, expected level should be 2.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultController.java
Line 17 in 86660b2
@GetMapping("/pr/{pullRequestId}") |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def' child has incorrect indentation level 8, expected level should be 4.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultController.java
Line 20 in 86660b2
throw new NotImplementedError("Not implemented yet"); |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def rcurly' has incorrect indentation level 4, expected level should be 2.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultController.java
Line 21 in 86660b2
} |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def modifier' has incorrect indentation level 4, expected level should be 2.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultController.java
Line 23 in 86660b2
@GetMapping("/branch") |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 110).
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultController.java
Line 24 in 86660b2
public ResponseEntity<List<TestResult>> getTestResultsByBranchAndHeadCommit(@RequestParam String branch) { |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def' child has incorrect indentation level 8, expected level should be 4.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultController.java
Line 25 in 86660b2
throw new NotImplementedError("Not implemented yet"); |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def rcurly' has incorrect indentation level 4, expected level should be 2.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultController.java
Line 26 in 86660b2
} |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.NonEmptyAtclauseDescriptionCheck> reported by reviewdog 🐶
At-clause should have a non-empty description.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/github/GitHubService.java
Line 107 in 86660b2
* @throws IOException |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.RequireEmptyLineBeforeBlockTagGroupCheck> reported by reviewdog 🐶
Javadoc tag '@param' should be preceded with an empty line.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/github/GitHubService.java
Line 107 in 86660b2
* @throws IOException |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocMethodCheck> reported by reviewdog 🐶
Unused @param tag for 'repoNameWithOwners'.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/github/GitHubService.java
Line 107 in 86660b2
* @throws IOException |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.javadoc.NonEmptyAtclauseDescriptionCheck> reported by reviewdog 🐶
At-clause should have a non-empty description.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/github/GitHubService.java
Line 109 in 86660b2
public PagedIterable<GHArtifact> getWorkflowRunArtifacts(long repoId, long workflowRunId) throws IOException { |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 112).
There hasn't been any activity on this pull request recently. Therefore, this pull request has been automatically marked as stale and will be closed if no further activity occurs within seven days. Thank you for your contributions. |
86660b2
to
8613c40
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
checkstyle
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def' child has incorrect indentation level 8, expected level should be 4.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultProcessor.java
Line 71 in 8613c40
results.forEach(result -> { |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'block' child has incorrect indentation level 12, expected level should be 10.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultProcessor.java
Line 72 in 8613c40
final TestResult testResult = new TestResult(); |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'block' child has incorrect indentation level 12, expected level should be 10.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultProcessor.java
Line 73 in 8613c40
testResult.setWorkflowRun(workflowRun); |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'block' child has incorrect indentation level 12, expected level should be 10.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultProcessor.java
Line 74 in 8613c40
testResult.setTotal(result.total()); |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'block' child has incorrect indentation level 12, expected level should be 10.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultProcessor.java
Line 75 in 8613c40
testResult.setPassed(result.passed()); |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'block' child has incorrect indentation level 12, expected level should be 10.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultProcessor.java
Line 76 in 8613c40
testResult.setFailures(result.failures()); |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'block' child has incorrect indentation level 12, expected level should be 10.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultProcessor.java
Line 77 in 8613c40
testResult.setErrors(result.errors()); |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'block' child has incorrect indentation level 12, expected level should be 10.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultProcessor.java
Line 78 in 8613c40
testResult.setSkipped(result.skipped()); |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'block' child has incorrect indentation level 12, expected level should be 10.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultProcessor.java
Line 79 in 8613c40
testResultRepository.save(testResult); |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def' child has incorrect indentation level 8, expected level should be 4.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultProcessor.java
Line 82 in 8613c40
log.debug("Persisted test results"); |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def rcurly' has incorrect indentation level 4, expected level should be 2.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultProcessor.java
Line 83 in 8613c40
} |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.sizes.LineLengthCheck> reported by reviewdog 🐶
Line is longer than 100 characters (found 102).
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultProcessor.java
Line 85 in 8613c40
private List<TestParserResult> processTestResultArtifact(GHArtifact artifact) throws IOException { |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def modifier' has incorrect indentation level 4, expected level should be 2.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultProcessor.java
Line 85 in 8613c40
private List<TestParserResult> processTestResultArtifact(GHArtifact artifact) throws IOException { |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def' child has incorrect indentation level 8, expected level should be 4.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultProcessor.java
Line 87 in 8613c40
return artifact.download(stream -> { |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'block' child has incorrect indentation level 12, expected level should be 10.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultProcessor.java
Line 88 in 8613c40
List<TestParserResult> results = new ArrayList<>(); |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'try' has incorrect indentation level 12, expected level should be 10.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultProcessor.java
Line 90 in 8613c40
try (ZipInputStream zipInput = new ZipInputStream(stream)) { |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'try' child has incorrect indentation level 16, expected level should be 12.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultProcessor.java
Line 91 in 8613c40
ZipEntry entry; |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'while' has incorrect indentation level 16, expected level should be 12.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultProcessor.java
Line 93 in 8613c40
while ((entry = zipInput.getNextEntry()) != null) { |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'if' has incorrect indentation level 20, expected level should be 14.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultProcessor.java
Line 94 in 8613c40
if (!entry.isDirectory()) { |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'if' has incorrect indentation level 24, expected level should be 16.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultProcessor.java
Line 95 in 8613c40
if (this.junitParser.supports(entry.getName())) { |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'if' child has incorrect indentation level 28, expected level should be 18.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultProcessor.java
Line 96 in 8613c40
results.add(this.junitParser.parse(zipInput)); |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'if rcurly' has incorrect indentation level 24, expected level should be 16.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultProcessor.java
Line 97 in 8613c40
} |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'if rcurly' has incorrect indentation level 20, expected level should be 14.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultProcessor.java
Line 98 in 8613c40
} |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'while' child has incorrect indentation level 20, expected level should be 14.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultProcessor.java
Line 99 in 8613c40
zipInput.closeEntry(); |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'while rcurly' has incorrect indentation level 16, expected level should be 12.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultProcessor.java
Line 100 in 8613c40
} |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'try rcurly' has incorrect indentation level 12, expected level should be 10.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultProcessor.java
Line 101 in 8613c40
} |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'block' child has incorrect indentation level 12, expected level should be 10.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultProcessor.java
Line 103 in 8613c40
return results; |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def rcurly' has incorrect indentation level 4, expected level should be 2.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/TestResultProcessor.java
Line 105 in 8613c40
} |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'ctor def modifier' has incorrect indentation level 4, expected level should be 2.
Line 4 in 8613c40
public TestResultParseException(String message, Throwable cause) { |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'ctor def' child has incorrect indentation level 8, expected level should be 4.
Line 5 in 8613c40
super(message, cause); |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'ctor def rcurly' has incorrect indentation level 4, expected level should be 2.
Line 6 in 8613c40
} |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.naming.AbbreviationAsWordInNameCheck> reported by reviewdog 🐶
Abbreviation in name 'JUnitParser' must contain no more than '1' consecutive capital letters.
Helios/server/application-server/src/main/java/de/tum/cit/aet/helios/tests/parsers/JUnitParser.java
Line 14 in 8613c40
public class JUnitParser implements TestResultParser { |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def modifier' has incorrect indentation level 4, expected level should be 2.
Line 6 in 8613c40
TestParserResult parse(InputStream content); |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def modifier' has incorrect indentation level 4, expected level should be 2.
Line 8 in 8613c40
boolean supports(String artifactName); |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'compact ctor def modifier' has incorrect indentation level 4, expected level should be 2.
Line 4 in 8613c40
public TestParserResult { |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'if' has incorrect indentation level 8, expected level should be 4.
Line 5 in 8613c40
if (total < 0 || failures < 0 || errors < 0 || skipped < 0 || time < 0) { |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'if' child has incorrect indentation level 12, expected level should be 6.
Line 6 in 8613c40
throw new IllegalArgumentException("Negative values not allowed"); |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'if rcurly' has incorrect indentation level 8, expected level should be 4.
Line 7 in 8613c40
} |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'compact ctor def rcurly' has incorrect indentation level 4, expected level should be 2.
Line 8 in 8613c40
} |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def modifier' has incorrect indentation level 4, expected level should be 2.
Line 10 in 8613c40
public int passed() { |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def' child has incorrect indentation level 8, expected level should be 4.
Line 11 in 8613c40
return total - failures - errors - skipped; |
🚫 [checkstyle] <com.puppycrawl.tools.checkstyle.checks.indentation.IndentationCheck> reported by reviewdog 🐶
'method def rcurly' has incorrect indentation level 4, expected level should be 2.
Coverage summary from CodacySee diff coverage on Codacy
Coverage variation details
Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: Diff coverage details
Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: See your quality gate settings Change summary preferencesCodacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Tested it for the test repo, and it works perfectly! I think we can merge it, because it doesn't introduce any breaking changes, and if we encounter some issues with the Artemis just fix them later 👍
I started looking into the implementation of our test case overview that we want to show within Helios in the near future for branches and PRs. Right now, we're only showing the checks/status of the workflow runs.
Objective
This PR will cover a first implementation of a test processing pipeline that will create
TestSuite
and correspondingTestCase
entities based on one or multiple JUnit Report XML files that are uploaded as artifacts by a workflow run. Additionally, I want to display the results in a simple way within the branch and PR details view.Current pipeline
PagedIterator
)Conditions
Screenshot/Video
recording.mov
Additional changes
Testing
I created a repository that contains two test workflows:
test-artemis.yml
uploads the results of a full Artemis test with 1 failuretest.yml
actually runs the tests of a Spring boot application, however there is just one test in there right nowIn order to test it, you'll have to set
REPOSITORY_NAME
in your env variables toege-test-org/test-junit-repo
, let it sync, set the labels oftest-artemis.yml
,test.yml
or both to "TEST" within the project settings, set up a webhook withinege-test-org/test-junit-repo
and trigger a test run (just change a file and push to main).Future Work