Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: UI Refactoring #359

Merged
merged 90 commits into from
Feb 17, 2025
Merged

feat: UI Refactoring #359

merged 90 commits into from
Feb 17, 2025

Conversation

egekocabas
Copy link
Member

@egekocabas egekocabas commented Feb 10, 2025 •
edited
Loading

Motivation

This PR includes various client-side fixes and refactoring. Let's review it on Tuesday.

Description

  • Moved static assets to public.
  • Updated router paths
    • Root now shows the repository list directly, removing /repo/list
    • Adjusted related components.
  • Unified navigation bar logic by generalizing MainLayoutComponent, which now detects repository context dynamically.
  • Added app-navigation-bar to control button visibility.
  • Introduced footer with about, privacy, and imprint pages.
  • Fixed scroll issue in the new release header.
  • Displaying GitHub profile picture instead of initials after login.
  • Made navigation bar expandable.
  • Created a reusable PR status component.
  • Improved PR and branch detail views resembling GitHub.
  • Refactored repository overview to use a table view.

Screenshots

Screen.Recording.2025-02-17.at.15.26.36.mov

@egekocabas
use user icon in pr view and also add new pull request status icon co…
2241c10 
…mponent
@egekocabas
use new pr icon component
3be4185
@egekocabas
centralize the user avatar component
82f82fb
@egekocabas
use markdown pipe for branch's latest commit
7df8c4e
@egekocabas
add undefined type for markdown pipe for avoiding typescript error
f41870c
@egekocabas
adjust pr/branch detail view
ea638bd
@egekocabas
adjust
be54239
@egekocabas
use profile picture in navigation bar
d62c858
@egekocabas
fix client test
b21dcdc
@egekocabas
fix header in readonly mode
375b3aa
@egekocabas
add footer
62e93f8
@egekocabas
separate navigation bar as its own component
c990f55
@egekocabas
init about page
607a87e
@egekocabas
update main layout logic
f6ed056
@egekocabas
nav bar updates
fd6900e
@egekocabas
move main layout at the top of the route
0ac5fb1
@egekocabas
refactor repository overview content
92ccd53
@egekocabas
remove connect repo component
dafc2f0
@egekocabas
remove repo redirect for main page
ef0c60e
@egekocabas
refactor heading to work without the repo id
1e537b4
@egekocabas
remove angular's favicon
a008665
@egekocabas
use assets folder for static files
59d97e0
@egekocabas
add about page
8912e8a
@egekocabas
rearrange report a bug button placement
659270d
@egekocabas
init imprint and privacy pages
cfcc09c
@egekocabas
lint
c778202
@egekocabas
fix pr open issue when pr link is clicked
7b96928
@egekocabas
open github branch page when branch name is clicked in pr details view
590f3ef
@helios-aet helios-aet bot deployed to test-server-2 February 14, 2025 00:39 Active
egekocabas and others added 15 commits February 16, 2025 21:07
@egekocabas egekocabas marked this pull request as ready for review February 17, 2025 14:51
@egekocabas egekocabas requested a review from thielpa February 17, 2025 14:51
@egekocabas
Copy link
Member Author

egekocabas commented Feb 17, 2025 •
edited
Loading

Covered all the topics and also updated the video recording 👍🏻

For some conversation topics, I left them open to see how/why I did it that way

Edit: Also used hephaestus & prompt2's public pages to align with our home/privacy/imprint

thielpa
thielpa approved these changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@thielpa thielpa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, thanks for all the changes!

@egekocabas
Merge remote-tracking branch 'origin/staging' into feat/ui-refactoring
4c1451b 
# Conflicts:
#	client/src/app/pages/main-layout/main-layout.component.ts
@egekocabas
lint
26e4ac7
@egekocabas egekocabas merged commit 0e91470 into staging Feb 17, 2025
12 of 13 checks passed
@egekocabas egekocabas deleted the feat/ui-refactoring branch February 17, 2025 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thielpa thielpa thielpa approved these changes

Assignees

@egekocabas egekocabas

Labels
client feature ready for review size:XXL
Projects
None yet
Milestone
No milestone
2 participants
@egekocabas @thielpa