Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add delete of release candidates #366

Merged
merged 2 commits into from
Feb 17, 2025
Merged

feat: Add delete of release candidates #366

merged 2 commits into from
Feb 17, 2025

Conversation

thielpa
Copy link
Contributor

@thielpa thielpa commented Feb 14, 2025

This PR adds the possibility to delete release candidates.

image

@thielpa thielpa changed the title feat: add delete of release candidates feat: Add delete of release candidates Feb 14, 2025
Copy link

codacy-production bot commented Feb 14, 2025

Coverage summary from Codacy

See diff coverage on Codacy

Coverage variation Diff coverage
Report missing for a7413b01 13.33%
Coverage variation details
Coverable lines Covered lines Coverage
Common ancestor commit (a7413b0) Report Missing Report Missing Report Missing
Head commit (3b032e8) 5245 322 6.14%

Coverage variation is the difference between the coverage for the head and common ancestor commits of the pull request branch: <coverage of head commit> - <coverage of common ancestor commit>

Diff coverage details
Coverable lines Covered lines Diff coverage
Pull request (#366) 15 2 13.33%

Diff coverage is the percentage of lines that are covered by tests out of the coverable lines that the pull request added or modified: <covered lines added or modified>/<coverable lines added or modified> * 100%

See your quality gate settings    Change summary preferences

Codacy stopped sending the deprecated coverage status on June 5th, 2024. Learn more

Footnotes

  1. Codacy didn't receive coverage data for the commit, or there was an error processing the received data. Check your integration for errors and validate that your coverage setup is correct.

@thielpa thielpa marked this pull request as ready for review February 14, 2025 00:18
@thielpa thielpa requested a review from a team as a code owner February 14, 2025 00:18
Copy link
Member

@egekocabas egekocabas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only did the code review I will run and test it later but it looks pretty good and clean 👍🏻

Copy link
Member

@egekocabas egekocabas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally LGTM 🚀

(I have updated the PR with latest staging changes; while squash merging, do not forget to remove me from the commit as the co-author 👍🏻 )

@thielpa thielpa merged commit e5a2024 into staging Feb 17, 2025
13 checks passed
@thielpa thielpa deleted the delete-rcs branch February 17, 2025 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants