remove TODO comments(#223)

ls1intum · Jan 22, 2025 · 79c3666 · 79c3666
1 parent 17dff30
commit 79c3666
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 40 deletions.
diff --git a/...e/tum/in/www1/hephaestus/activity/badpracticedetector/PullRequestBadPracticeDetector.java b/...e/tum/in/www1/hephaestus/activity/badpracticedetector/PullRequestBadPracticeDetector.java
@@ -24,44 +24,6 @@ public List<PullRequestBadPractice> detectAndSyncBadPractices(PullRequest pullRe
             pullRequest.getId()
         );
 
-        //TODO connect LLM based detection
-        List<PullRequestBadPractice> newBadPractices = List.of();
-
-        return newBadPractices;
-    }
-    /*
-        updateExistingBadPractices(existingBadPractices, newBadPractices);
-
-        return saveBadPractices(existingBadPractices, newBadPractices);
-    }
-
-    private List<PullRequestBadPractice> saveBadPractices(
-        List<PullRequestBadPractice> existingBadPractices,
-        List<PullRequestBadPractice> detectedBadPractices
-    ) {
-        List<PullRequestBadPractice> newBadPractices = detectedBadPractices
-            .stream()
-            .filter(badPractice -> !existingBadPractices.contains(badPractice))
-            .toList();
-
-        return pullRequestBadPracticeRepository.saveAll(newBadPractices);
+        return existingBadPractices;
     }
-
-    private void updateExistingBadPractices(
-        List<PullRequestBadPractice> existingBadPractices,
-        List<PullRequestBadPractice> detectedBadPractices
-    ) {
-        List<PullRequestBadPracticeType> types = detectedBadPractices
-            .stream()
-            .map(PullRequestBadPractice::getType)
-            .toList();
-
-        for (PullRequestBadPractice existingBadPractice : existingBadPractices) {
-            if (!types.contains(existingBadPractice.getType())) {
-                logger.info("Resolving bad practice: {}", existingBadPractice.getType());
-                existingBadPractice.setResolved(true);
-                pullRequestBadPracticeRepository.save(existingBadPractice);
-            }
-        }
-    }*/
 }
diff --git a/server/application-server/src/main/java/de/tum/in/www1/hephaestus/gitprovider/user/User.java b/server/application-server/src/main/java/de/tum/in/www1/hephaestus/gitprovider/user/User.java
@@ -14,7 +14,6 @@
 import jakarta.persistence.ManyToMany;
 import jakarta.persistence.OneToMany;
 import jakarta.persistence.Table;
-
 import java.time.OffsetDateTime;
 import java.util.HashSet;
 import java.util.Set;