-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improvement
: Markdown code block adjustments
#308
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks generally good to me
I just noticed this, too. Let's put this PR on hold for now and discuss the details later. I think with a similar approach we can manage to apply the rounded corners correctly, maybe for images, too. |
@julian-wls What is the status on this PR? In case you do not plan to work on this in the next week, I'd suggest to maybe close this PR for now and re-open it later, so we can keep the PR overview page clean 😅 |
Yes sure :) I'm going to revert the rounded corners for code blocks as this didn't lead anywhere so we only have the color adjustments and can put it back in review. |
…ments' into improvement/markdown-code-adjustments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one code comment, good to merge from my side :)
Problem Description
Code blocks in markdown text look different from the iOS and web app.
Changes
This PR changes the colors of the code blocks and adds rounded corners.
Steps for testing
Make sure the code block still looks good.
Further investigation
wrapContentSize
is needed to make it work properly. Unfortunately, this caused some of the images in the chat to be too small. The approach was similar to clipping code blocks. Does anyone have an idea how to make this work? I would be happy to discuss this somewhere.