Feature: Add remaining search bars
#407
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… as the bottom navigation bar
julian-wls
changed the title
Feature: Add remaining search bars
|
Oh boooy, I love the animation when clicking the search bar 😍 One thing I am concerned about is the occupied space by the search bar, especially in tablet mode however. The screen is quite cluttered with Navigation bars. One idea might be make the TopBar collapsable on scroll, and force the topbar to be collapsed in the tablet mode as soon as entering a chat. The collapsed TopBar state could looks like the "old" TopBar, but with a search icon on the top right, to still allow users to switch to the search mode. I'm really just brain storming at this point though, so let me know what you think! |
# Conflicts: # core/ui/src/main/kotlin/de/tum/informatics/www1/artemis/native_app/core/ui/common/BasicArtemisTextField.kt # feature/metis/conversation/src/main/kotlin/de/tum/informatics/www1/artemis/native_app/feature/metis/conversation/ui/ConversationChatListScreen.kt # feature/metis/manage-conversations/src/main/kotlin/de/tum/informatics/www1/artemis/native_app/feature/metis/manageconversations/ui/conversation/browse_channels/BrowseChannelsScreen.kt
Base automatically changed from
improvement/add-elevation-to-top-bar
to
develop
February 13, 2025 10:10
FelberMartin
requested changes
Feb 14, 2025
...in/de/tum/informatics/www1/artemis/native_app/core/ui/common/top_app_bar/ArtemisTopAppBar.kt
Outdated
Show resolved
Hide resolved
...in/de/tum/informatics/www1/artemis/native_app/core/ui/common/top_app_bar/ArtemisTopAppBar.kt
Outdated
Show resolved
Hide resolved
...in/de/tum/informatics/www1/artemis/native_app/core/ui/common/top_app_bar/ArtemisTopAppBar.kt
Show resolved
Hide resolved
...in/de/tum/informatics/www1/artemis/native_app/core/ui/common/top_app_bar/ArtemisTopAppBar.kt
Outdated
Show resolved
Hide resolved
...i/src/main/kotlin/de/tum/informatics/www1/artemis/native_app/core/ui/common/EmptyListHint.kt
Outdated
Show resolved
Hide resolved
...um/informatics/www1/artemis/native_app/feature/courseview/ui/exercise_list/ExerciseListUi.kt
Outdated
Show resolved
Hide resolved
...ain/kotlin/de/tum/informatics/www1/artemis/native_app/feature/courseview/ui/LectureListUi.kt
Outdated
Show resolved
Hide resolved
...in/kotlin/de/tum/informatics/www1/artemis/native_app/feature/dashboard/ui/CoursesOverview.kt
Outdated
Show resolved
Hide resolved
...in/de/tum/informatics/www1/artemis/native_app/feature/metis/ui/SinglePageConversationBody.kt
Outdated
Show resolved
Hide resolved
...pp/feature/metis/manageconversations/ui/conversation/browse_channels/BrowseChannelsScreen.kt
Show resolved
Hide resolved
...n/kotlin/de/tum/informatics/www1/artemis/native_app/feature/faq/ui/overview/FaqOverviewUi.kt
Outdated
Show resolved
Hide resolved
eylulnc
reviewed
Feb 15, 2025
FelberMartin
approved these changes
Feb 17, 2025
FelberMartin
added
ready to merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Description
Some of the screens in the app do not have search bars yet, see #378.
Changes
This PR introduces a new ArtemisSearchTopAppBar, which has a built in search bar and is used across the different screens of the course. Filtering functionality has been added for the lecture, exercise and browse channels screen. The search bar of the conversations screen and the member screen has been updated to use the new ArtemisSearchTopAppBar.
Important note:
There are two E2E tests that are currently failing, because of some modifications I had to make to the search bar. These modifications are also made in #384 including fixes for these tests. Once #384 is merged the tests will not fail anymore.
Steps for testing
Screenshots