-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix
: Fix emoji icon scaling
#408
base: develop
Are you sure you want to change the base?
Conversation
Bugfix
: Fixed emoji icon scalingBugfix
: Fix emoji icon scaling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
...in/de/tum/informatics/www1/artemis/native_app/feature/metis/conversation/ui/post/PostItem.kt
Outdated
Show resolved
Hide resolved
Hm interesting, I re-tested on both foldable and physical device, and in both cases the icon size was off for the largest font size🤔 Recording.2025-02-13.112544.mp4 |
Oh, okay. I was using the font scaling in the accessibility options of the Android system settings app. There seem to be only 5 different text sizes, which all look good now. |
Problem Description
Currently, the icon for the add emoji button seems a bit too big and not aligned, see screenshot:

It looks fine when the text size is bigger than usual, but not with the normal scaling.
Changes
This PR changes the height of the emoji to use .sp to be affected from the font changes and therefore be aligned with the other emoji chips.
Steps for testing
Make sure it looks good before and after changing the font size.