Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Add course wide channels #416

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from

Conversation

eylulnc
Copy link
Contributor

@eylulnc eylulnc commented Feb 13, 2025

Problem Description

A new Course Scope option has been introduced in the Create Channel dialog, allowing users to choose between course-wide and selective channels, with selective set as the default. This functionality aligns with the existing implementation on the Web version to ensure consistency across platforms.

Changes

Toggle Added to the Create Channel View
Added isCourseWide: Boolean to the ChannelChat model.
Modified ConversationService to include isCourseWide as part of the channel creation request.

Steps for testing

Log in to Artemis.
Navigate to the Communication section of a course.
Click the plus (+) gab button and select Create Channel.
Observe the new Channel Scope option and select Course-wide to create a channel.
Verify that all course members are automatically added to the newly created channel.

Screenshots

Screenshot 2025-02-12 at 14 19 18

@eylulnc eylulnc self-assigned this Feb 13, 2025
@eylulnc eylulnc added the ready for review This PR can be reviewed label Feb 15, 2025
@eylulnc eylulnc linked an issue Feb 15, 2025 that may be closed by this pull request
Copy link
Contributor

@julian-wls julian-wls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice change, works as expected. All users were added to the channel.
Just one general remark, see below

@eylulnc eylulnc requested a review from julian-wls February 17, 2025 19:33
Copy link
Contributor

@julian-wls julian-wls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm now 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review This PR can be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Channel creation: Add course-wide option
2 participants