DM-51670: Add bbox property to BlendData classes#22
Conversation
8394830 to
b1c180d
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #22 +/- ##
==========================================
- Coverage 92.56% 92.41% -0.16%
==========================================
Files 49 49
Lines 5410 5432 +22
==========================================
+ Hits 5008 5020 +12
- Misses 402 412 +10 ☔ View full report in Codecov by Sentry. |
8972a1d to
74961b3
Compare
python/lsst/scarlet/lite/io/blend.py
Outdated
| sources: dict[Any, ScarletSourceBaseData] | ||
| version: str = CURRENT_SCHEMA | ||
|
|
||
| @property |
There was a problem hiding this comment.
Maybe make this a cached_property? It seems unusual to have a property return a new object every time, unless the Box's shape/origin can be reassigned. But then maybe it should be e.g. make_box.
There was a problem hiding this comment.
I wasn't family with cached_property, thanks for the suggestion. I wasn't too worried about it because this is not normally called and it's an inexpensive operation but since it should never change using cached_property seems like the way to go.
74961b3 to
9d32d40
Compare
Checklist
doc/changes