Skip to content

DM-51670: Add bbox property to BlendData classes#22

Merged
fred3m merged 1 commit intomainfrom
tickets/DM-51670
Nov 27, 2025
Merged

DM-51670: Add bbox property to BlendData classes#22
fred3m merged 1 commit intomainfrom
tickets/DM-51670

Conversation

@fred3m
Copy link
Collaborator

@fred3m fred3m commented Nov 16, 2025

Checklist

  • ran Jenkins
  • added a release note for user-visible changes to doc/changes

@codecov
Copy link

codecov bot commented Nov 16, 2025

Codecov Report

❌ Patch coverage is 56.52174% with 10 lines in your changes missing coverage. Please review.
✅ Project coverage is 92.41%. Comparing base (a2180ab) to head (9d32d40).
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
python/lsst/scarlet/lite/io/hierarchical_blend.py 23.07% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #22      +/-   ##
==========================================
- Coverage   92.56%   92.41%   -0.16%     
==========================================
  Files          49       49              
  Lines        5410     5432      +22     
==========================================
+ Hits         5008     5020      +12     
- Misses        402      412      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sources: dict[Any, ScarletSourceBaseData]
version: str = CURRENT_SCHEMA

@property
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe make this a cached_property? It seems unusual to have a property return a new object every time, unless the Box's shape/origin can be reassigned. But then maybe it should be e.g. make_box.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't family with cached_property, thanks for the suggestion. I wasn't too worried about it because this is not normally called and it's an inexpensive operation but since it should never change using cached_property seems like the way to go.

@fred3m fred3m merged commit 00274db into main Nov 27, 2025
15 of 17 checks passed
@fred3m fred3m deleted the tickets/DM-51670 branch November 27, 2025 01:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants