DM-53933: Fix crash when healpix pixelization is used with a nearly-degenerate polygon.#96
DM-53933: Fix crash when healpix pixelization is used with a nearly-degenerate polygon.#96
Conversation
erykoff
force-pushed
the
tickets/DM-53933
branch
from
86516fd to
53579d3
Compare
| @@ -0,0 +1 @@ | |||
| Fixed crash that could occur when a nearly degenerate polygon was used with healpix pixelization. | |||
There was a problem hiding this comment.
Thank you for adding a news fragment. We've never really done that in this package before. Can you please fix the file name so it follows the towncrier convention of DM-53933.bugfix.md ?
There was a problem hiding this comment.
The PR template says to add a note! But there were no notes already there to remind me what the format was. Anyway, the filename has been fixed.
fred3m
left a comment
fred3m
left a comment
There was a problem hiding this comment.
LGTM, just one comment/question regarding the implementation.
| retry = True | ||
|
|
||
| if retry: | ||
| pixels = self._interior_pixels_from_region(nside, region.getBoundingCircle()) |
There was a problem hiding this comment.
What is the advantage of using the retry variable here as opposed to just setting pixels = self._interior_pixels_from_region(nside, region.getBoundingCircle()) in the except block?
There was a problem hiding this comment.
I was afraid of something going wrong with recursion inside a try/except but maybe that's just superstition.
erykoff
force-pushed
the
tickets/DM-53933
branch
from
53579d3 to
b83a87a
Compare
3 participants
Checklist
doc/changes